-
Notifications
You must be signed in to change notification settings - Fork 13
feat: Add Farcaster miniapp support for identity verification flow #10 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vortex-hue
wants to merge
43
commits into
GoodDollar:main
Choose a base branch
from
vortex-hue:add-farcaster-support-for-the-identity-flow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 42 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
25ee077
Feat: Installed farcaster package
vortex-hue 42fc37e
fix: build errors
vortex-hue 9557dce
feat: Add Farcaster miniapp support for identity flow with build fixes
vortex-hue 42e08a9
rm eslintrc
vortex-hue 64d56a8
refactor: Address code review feedback with improved architecture acr…
vortex-hue 3323d82
fix: Address code review complaints
vortex-hue 8bff2fe
fix: working on resolving the reviews made
vortex-hue f3940b2
fix: removed dynamic import, and reverted some configs to the default…
vortex-hue 53564da
pulled update
vortex-hue 60eb1cb
fix: Addressed all outstanding code review feedback.
vortex-hue c105e1b
fix: resolved all code changes requested
vortex-hue e10b584
feat: implement shared build config utility for Node.js built-ins and…
vortex-hue 8edaca1
revert: removed the shared build config changes and other changes
vortex-hue c34de25
fc:frame meta tag
vortex-hue f6889fd
fix: refined the codebase
vortex-hue 8616d89
fix:patching up the codebase
vortex-hue 36dfa32
Revert "fix:patching up the codebase"
vortex-hue 5ed0e06
revert: reverted all changes requested
vortex-hue 5bdab21
revert: reverted all changes requested
vortex-hue cd6d40f
revert: reverted all changes requested
vortex-hue f1e9b8d
fix: revert changes requested
vortex-hue b7de6cb
fix: revert changes requested
vortex-hue 304c15a
fix: revert changes affecting mobile
vortex-hue 9841794
feat: implemented the universal link using farcaster docs
vortex-hue d19d211
fix: resolving previous issues
vortex-hue 158465a
fix: resolved redirection concerns and fixed bugs
vortex-hue 4060809
Merge remote-tracking branch 'origin/main' into add-farcaster-support…
vortex-hue e6ba4d0
fix: build id working well now
vortex-hue 8cf55a7
fix: remove the unused interface of VerifyButtonProps
vortex-hue c1486dc
fix: removed the used import { createUniversalLinkCallback } from ../…
vortex-hue 04ff59c
fix: revert apps/demo-identity-app/src/App.tsx and verifybutton.tsx t…
vortex-hue 3dd1832
Merge upstream/main into add-farcaster-support-for-the-identity-flow
vortex-hue 59484bc
fix: update auth.ts to use chainConfigs instead of contractAddresses
vortex-hue f620a1c
Merge remote-tracking branch 'upstream/main' into add-farcaster-suppo…
vortex-hue c38476f
refactor: apply engineering principles to Farcaster implementation
vortex-hue 20d0905
refactor: clean up demo app following engineering principles
vortex-hue 9a9dbbc
fix: address code review feedback
vortex-hue 7a7a921
fix: address round 3 code review comments (restore comments, fix fvRe…
vortex-hue 994b4f3
fix: address PR review feedback from L03TJ3
vortex-hue 75a9b45
fix: address round 2 PR review feedback from sirpy
vortex-hue 6377bf0
chore: merge upstream/main and regenerate yarn.lock
vortex-hue 359e2c2
feat: add navigateToFaceVerification with Farcaster-aware redirect
vortex-hue 4ad2886
refactor: remove Farcaster config coupling from SDK internals
vortex-hue File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,4 +10,4 @@ | |
| <div id="app"></div> | ||
| <script type="module" src="/src/main.tsx"></script> | ||
| </body> | ||
| </html> | ||
| </html> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,4 +31,4 @@ export default defineConfig({ | |
| "process.browser": true, | ||
| "process.env": process.env, | ||
| }, | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,4 +25,4 @@ export default defineConfig({ | |
| "process.browser": true, | ||
| "process.env": process.env, | ||
| }, | ||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,4 @@ | ||
| export * from "./sdks" | ||
| export * from "./constants" | ||
| export * from "./utils/auth" | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| export * from "./viem-identity-sdk" | ||
| export * from "./viem-claim-sdk" | ||
| export * from "./viem-custodial-claim-sdk" | ||
| export * from "./viem-custodial-identity-sdk" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this removed