fix: Reset bridging state and amount after bridge operations and adju…#255
Open
EmekaManuel wants to merge 3 commits intoGoodDollar:masterfrom
Open
fix: Reset bridging state and amount after bridge operations and adju…#255EmekaManuel wants to merge 3 commits intoGoodDollar:masterfrom
EmekaManuel wants to merge 3 commits intoGoodDollar:masterfrom
Conversation
…st fee label styling.
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- In the
useEffectwhere you addedsetBridgeAmountto the dependency array, consider also addingsetBridgingfor consistency with how state setters are treated and to avoid future confusion or lint discrepancies. - Resetting the bridge amount to the string "0" on success might be interpreted by the UI as an explicit numeric value rather than an empty/default state; consider whether an empty string or
nullwould better reflect a cleared input from a UX and validation perspective.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the `useEffect` where you added `setBridgeAmount` to the dependency array, consider also adding `setBridging` for consistency with how state setters are treated and to avoid future confusion or lint discrepancies.
- Resetting the bridge amount to the string "0" on success might be interpreted by the UI as an explicit numeric value rather than an empty/default state; consider whether an empty string or `null` would better reflect a cleared input from a UX and validation perspective.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…ect dependencies.
Author
|
hi @L03TJ3 , kindly review |
Collaborator
Collaborator
|
@EmekaManuel hey, verifying if the latest comments are being worked on? |
Author
|
yes please |
…ly, and improving prop handling
Contributor
|
@EmekaManuel please provide video showing the bugs were fixed |
Contributor
|
@EmekaManuel waiting for your reply |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug: Fix Microbridge UI/UX Issues
#251
Description
This PR fixes two UI/UX bugs in the microbridge flow that were preventing users from creating multiple bridge transactions and causing visual inconsistency in the transaction history.
Issues Fixed
isBridging State Not Resetting: After creating a bridge request, users were unable to create another transaction because the
isBridgingstate was never reset, blocking the UI even after the transaction completed successfully or failed.Oversized Fees Font: The "Fees:" label in the microbridge transaction history had an unnecessarily bold font weight (
fontWeight="700") that didn't match the rest of the design, creating visual inconsistency.Changes Made
1. MicroBridge.tsx
setBridging(false)in both success and failure cases to reset the bridging statesetBridgeAmount("0")on success to clear the input field for the next transactionuseEffectdependency array to includesetBridgeAmountImpact: Users can now immediately create another bridge request after a transaction completes, without being blocked by the UI state.
2. MicroBridgeController.tsx
fontWeight="700"from the "Fees:" label in theHistoryRowItemcomponentvariant="xs-grey"styling as other transaction detailsImpact: Consistent font styling across all transaction history elements, improving visual hierarchy and readability.