fix: improve G$ calculator text readability#257
Open
supersonicwisd1 wants to merge 5 commits intoGoodDollar:masterfrom
Open
fix: improve G$ calculator text readability#257supersonicwisd1 wants to merge 5 commits intoGoodDollar:masterfrom
supersonicwisd1 wants to merge 5 commits intoGoodDollar:masterfrom
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider extracting the repeated text style props (e.g.,
fontSize,fontWeight,colorfor title and currency unit) into a shared style or themed variant so the visual pattern stays consistent and easier to update across similar components. - The
fontSize="2xl"on the input is quite large relative to the surrounding labels; double-check that this doesn’t break layout on smaller viewports or cause truncation within themaxW={220}constraint.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider extracting the repeated text style props (e.g., `fontSize`, `fontWeight`, `color` for title and currency unit) into a shared style or themed variant so the visual pattern stays consistent and easier to update across similar components.
- The `fontSize="2xl"` on the input is quite large relative to the surrounding labels; double-check that this doesn’t break layout on smaller viewports or cause truncation within the `maxW={220}` constraint.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
5 tasks
Contributor
|
@supersonicwisd1 can you show a video of the storybook showing the fixes? |
Author
It has been added to the description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The calculator component had three Text elements with no styling applied:
This made the text very difficult to read, especially when the calculator dropdown is opened.
Changes
fontSize="sm",fontWeight="500",color="goodGrey.600"fontSize={6}to semanticfontSize="2xl"color="goodGrey.800"for better contrastfontSize="md",fontWeight="600",color="goodGrey.600",mt={1}Related
Testing
Demo Video
Screen.Recording.2026-02-26.at.14.37.31.mov
Video showing Converter calculator with improved styling