Skip to content

fix: improve G$ calculator text readability#257

Open
supersonicwisd1 wants to merge 5 commits intoGoodDollar:masterfrom
supersonicwisd1:fix/calculator-styling
Open

fix: improve G$ calculator text readability#257
supersonicwisd1 wants to merge 5 commits intoGoodDollar:masterfrom
supersonicwisd1:fix/calculator-styling

Conversation

@supersonicwisd1
Copy link

@supersonicwisd1 supersonicwisd1 commented Dec 19, 2025

Summary

  • Fixes styling issues in the G$ Calculator component where input values were barely readable when the dropdown is opened.
  • Includes updated onramper widget
  • Includes required URL-signing
  • Blocked by server-side signing endpoint

Problem

The calculator component had three Text elements with no styling applied:

  • Title text ("With", "You'll get") - no font size, weight, or color
  • Input field - using numeric fontSize instead of semantic tokens
  • Currency unit labels (cUSD/G$) - no styling at all

This made the text very difficult to read, especially when the calculator dropdown is opened.

Changes

  • Line 22: Added proper styling to title text
    • fontSize="sm", fontWeight="500", color="goodGrey.600"
  • Line 27: Updated input field styling
    • Changed from fontSize={6} to semantic fontSize="2xl"
    • Added color="goodGrey.800" for better contrast
  • Line 40: Added styling to currency unit labels
    • fontSize="md", fontWeight="600", color="goodGrey.600", mt={1}

Related

Testing

  • Calculator text is now readable when dropdown is opened
  • Styling is consistent with Portfolio page design patterns
  • Built successfully with yalc
  • No breaking changes to component API
Screenshot 2025-12-19 at 21 50 17

Demo Video

Screen.Recording.2026-02-26.at.14.37.31.mov

Video showing Converter calculator with improved styling

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider extracting the repeated text style props (e.g., fontSize, fontWeight, color for title and currency unit) into a shared style or themed variant so the visual pattern stays consistent and easier to update across similar components.
  • The fontSize="2xl" on the input is quite large relative to the surrounding labels; double-check that this doesn’t break layout on smaller viewports or cause truncation within the maxW={220} constraint.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider extracting the repeated text style props (e.g., `fontSize`, `fontWeight`, `color` for title and currency unit) into a shared style or themed variant so the visual pattern stays consistent and easier to update across similar components.
- The `fontSize="2xl"` on the input is quite large relative to the surrounding labels; double-check that this doesn’t break layout on smaller viewports or cause truncation within the `maxW={220}` constraint.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sirpy
Copy link
Contributor

sirpy commented Feb 12, 2026

@supersonicwisd1 can you show a video of the storybook showing the fixes?

@supersonicwisd1
Copy link
Author

@supersonicwisd1 can you show a video of the storybook showing the fixes?

It has been added to the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants