Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie sharing example #565

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Cookie sharing example #565

wants to merge 2 commits into from

Conversation

dotproto
Copy link
Contributor

@dotproto dotproto commented Mar 5, 2021

This PR introduces a new Extensions example demonstrating how a coordinating website can share cookies with an extension.

Simeon Vincent added 2 commits March 5, 2021 09:09
My plan with this kind of readme is to explain example-specific concepts or
implementation details. In this case, we start with a brief note on the "key"
property in manifest.json.
@dotproto dotproto marked this pull request as ready for review March 10, 2021 19:25
@dotproto dotproto marked this pull request as draft March 10, 2021 19:27
domain: chrome.runtime.getURL(''),
});

console.log(cookies);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was like — this demo clearly has to do something! No wait, it's just logging nothing to console.

Screen Shot 2021-04-08 at 12 09 34

If I visit the site, then click on the button, I get this error. I'm not a cookie expert. I don't know what to make of this.

Copy link

@Linetkhgt Linetkhgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias

@oliverdunk
Copy link
Member

@dotproto Do you think this one is still worth working on or would it be best to close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants