Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sample of clicking an anchor element with the javascript: scheme #849

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

daidr
Copy link
Contributor

@daidr daidr commented Mar 15, 2023

Relevant issues: #807 #769

@AmySteam AmySteam requested review from oliverdunk and sebastianbenz and removed request for sebastianbenz March 22, 2023 20:57
@oliverdunk
Copy link
Member

@daidr, based on our email discussion would it be reasonable to call this a draft for now? Or would you like a review?

@daidr daidr marked this pull request as draft March 29, 2023 16:10
@daidr
Copy link
Contributor Author

daidr commented Mar 29, 2023

@daidr, based on our email discussion would it be reasonable to call this a draft for now? Or would you like a review?

I converted this to draft. Regarding the first issue I mentioned in the email, I tried upgrading Chrome and now the first demo no longer throws errors. However, I cannot pass element objects through events between the main world script and the isolated world script anymore. I will try to find a better way to pass the element that needs to be clicked and rewrite this sample in the next few days.

@daidr daidr marked this pull request as ready for review March 29, 2023 16:41
@jpmedley
Copy link
Contributor

@daidr, thank you for your hard work on this. So that you're not shocked, I want to let you know we will replace your instructions for unpacked loading with a link to ours. Something like this should theoretically included in every README. The problem is that if they ever change the UI for loading unpacked we'll have a maintenance problem on our hands.

@daidr
Copy link
Contributor Author

daidr commented Mar 29, 2023

@daidr, thank you for your hard work on this. So that you're not shocked, I want to let you know we will replace your instructions for unpacked loading with a link to ours. Something like this should theoretically included in every README. The problem is that if they ever change the UI for loading unpacked we'll have a maintenance problem on our hands.

I understand. What do I need to do?

@jpmedley
Copy link
Contributor

Just remove the loading instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants