deps(sentry): upgrade to v7#16215
Merged
connorjclark merged 1 commit intoGoogleChrome:mainfrom Oct 15, 2024
Merged
Conversation
@sentry/node to v7@sentry/node to v7
This comment was marked as resolved.
This comment was marked as resolved.
G-Rath
added a commit
to ackama/nzsl-share
that referenced
this pull request
Oct 15, 2024
We're currently blocked on patching this by GoogleChrome/lighthouse#16215
connorjclark
approved these changes
Oct 15, 2024
Collaborator
connorjclark
left a comment
There was a problem hiding this comment.
Thanks for the upgrade!
@sentry/node to v7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The current version of
@sentry/nodebrings in a vulnerable version of thecookiepackage (GHSA-pxg6-pf52-xh8x), which is not present in v7.This should be an easy bump as v7 was mainly about changes to the internals of Sentry so has a very small upgrade path: https://docs.sentry.io/platforms/javascript/migration/v6-to-v7/
Note that the latest is v8 but that has a lot more breaking changes in the public interface: https://docs.sentry.io/platforms/javascript/migration/v7-to-v8/
Related Issues/PRs
Relates to #16131