-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LoAF Summary attribution information #574
base: v5
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Barry! Left a few comments.
} | ||
totalScriptTime += script.duration; | ||
numScripts++; | ||
totalForcedStyleAndLayout += script.forcedStyleAndLayoutDuration; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's an open question whether we should only be taking the blocking/intersecting portion of all duration metrics. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately we can't for forced style and layout since we don't have the timings LoAF. Maybe that's a good reason to keep this simple and just take it for all intersecting scripts (which is what it does currently)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incidentally, it seems like we're leaning subparts
, not phases
for LCP, so we might want to do the same thing here (or object quickly on the LCP side of things :)
I'm cool with subparts so switched to that throughout. |
@rviscomi I've flattened the structure, and updated the comment in #574 (comment) to show that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll try it out in the next RC.
Fixes #559
Includes object like this: