Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update web-features from 1.0.0 to 2.15.0 #1020

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

jcscottiii
Copy link
Collaborator

@jcscottiii jcscottiii commented Dec 30, 2024

Notable things that have been added:

This commit also modifies the go code to add the new fields with sensible null / zero values since we don't need them yet. We have to add these fields to satisfy the exhaustruct linter.

Manual changes that we kept from #531:

  • Add an explicit StringorStringArray definition. Because it otherwise it takes the name of the first variable of it (previously Alias and now Caniuse) and uses it everywhere else. So all the usages would use Caniuse And that does not explain that the value could be a String or String Array.

Future PR

  • Rename the file from defs.schema.json to data.schema.json to reflect the updated filename in web features. Kept it as defs.schema.json because it would easier to see the diffs. Otherwise, there are enough changes where git thinks data.schema.json is a new file (even with git mv)

Notable things that have been added:
- Browser Release data. Now, we could actually remove the bcd job and migrate the logic into the web features job since we can get the same data from the v2.15.0 of the schema.

This commit also modifies the go code to add the new fields with sensible null / zero values since we don't need them yet. We have to add these fields to satisfy the [exhaustruct](https://github.com/GaijinEntertainment/go-exhaustruct) linter

Manual changes that we kept from #531:
- Add an explicit StringorStringArray definition. Because it otherwise it takes the name of the first variable of it (previously Alias and now Caniuse) and uses it everywhere else. So all the usages would use Caniuse And that does not explain that the value could be a String of String Array.
@jcscottiii jcscottiii added this pull request to the merge queue Dec 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 30, 2024
@jcscottiii jcscottiii added this pull request to the merge queue Dec 30, 2024
Merged via the queue into main with commit 489104c Dec 30, 2024
8 checks passed
@jcscottiii jcscottiii deleted the jcscottiii/update-defs-schema branch December 30, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants