Warn user when PiP fails #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Argh. I've noticed adding the notification permission will force people to re-enable permission when updated. I'm not sure if it's worth pursuing.
|
|
I agree that it's not worth pursuing. Is there any way we can do that? Like have the hover message be different? |
|
I'm not sure the hover message would work well. Maybe update the browser action icon instead. |
|
The icon could work. The issue would be that it may no longer match the
current state of the page if the main video changes and no longer has
disablePictureInPicture. Though maybe that's not too much of an issue?
…On Tue, 31 Mar 2020 at 11:46, François Beaufort ***@***.***> wrote:
I'm not sure the hover message would work well. Maybe update the browser
action icon instead.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEMBFTYGBNSCJYQBIS2FFDRKI3APANCNFSM4LXRHEJQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users are confused when clicking PiP button does not work as expected. See https://chrome.google.com/webstore/detail/picture-in-picture-extens/hkgfoiooedgoejojocmhlaklaeopbecg?hl=en
This PR aims to show a notification when it happens and also update statistics.
R: @mounirlamouri