Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Mv3 optimizations #78

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

nopeless
Copy link

@nopeless nopeless commented Sep 9, 2022

Update to manifestation version 3

This PR also includes minor performance optimizations and code fixes

backgrounnd.js currently cannot use attributes from document as manifest v3 does not expose that variable to the code.

If anyone knows how to fix this, please let me know

Thanks

@google-cla
Copy link

google-cla bot commented Sep 9, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@beaufortfrancois
Copy link
Collaborator

Thank you @nopeless
I've started a PR as well to migrate it to MV3 at #79
Let me know what you think

@beaufortfrancois
Copy link
Collaborator

@nopeless I've just published v1.11 with MV3 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants