Modernize code and improve readability #444
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Converting to draft until the code on main is sorted after #446. |
XhmikosR
force-pushed
the
xmr/dev
branch
8 times, most recently
from
965b7ca to
1f0f200
Compare
XhmikosR
force-pushed
the
xmr/dev
branch
2 times, most recently
from
0d4becd to
995f160
Compare
|
@addyosmani can you check the this PR and #403 and if everything looks good then cut a new minor version? This is what we have so far: 3.0.1...main |
@addyosmani friendly ping! |
|
@XhmikosR Yes! Apologies as my bandwidth is low at the moment. Would you prefer I review and land 403 first, 444, or no preference? |
|
@addyosmani no worries! Better land/review this PR and I can rebase #403 later :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an old patch I had lying around.
The size increase should be small, but I believe it makes code easier to read and also uses a few more modern features.
Non-whitespace diff: https://github.com/GoogleChromeLabs/quicklink/pull/444/files?w=1