[prometheus] Using $(hostname -s) vs ${HOSTNAME}#1152
Open
cjac wants to merge 1 commit intoGoogleCloudDataproc:mainfrom
Open
[prometheus] Using $(hostname -s) vs ${HOSTNAME}#1152cjac wants to merge 1 commit intoGoogleCloudDataproc:mainfrom
cjac wants to merge 1 commit intoGoogleCloudDataproc:mainfrom
Conversation
Recent change in the hostname implementation has required that we find short hostname using a different mechanism. This patch makes that change.
Contributor
Author
|
/gcbrun |
Contributor
Author
|
This is another action without tests. Should we add tests or remove the action? Since we do have documentation[1] about the init action, perhaps it is best to add the tests in this case. [1] https://cloud.google.com/monitoring/agent/ops-agent/prometheus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent change in the hostname implementation has required that we find short hostname using a different mechanism. This patch makes that change.