fix(dev-tools): make, not bash (#2691)

GoogleCloudPlatform · Nov 12, 2024 · ce77cac · ce77cac
1 parent 6a20dfb
commit ce77cac
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/.github/workflows/build-push-cft-devtools.yml b/.github/workflows/build-push-cft-devtools.yml
@@ -18,6 +18,7 @@ jobs:
     permissions:
       contents: 'read'
       id-token: 'write'
+      issues: 'write'
 
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

diff --git a/infra/build/Makefile b/infra/build/Makefile
@@ -115,10 +115,7 @@ build-image-developer-tools:
 
 .PHONY: release-image-developer-tools
 release-image-developer-tools:
-	if [[ -z "${GITHUB_SHA}" ]]; then
-	  echo "ERROR: Missing GITHUB_SHA for the release"
-		exit 1
-	fi
+	test -n "$(GITHUB_SHA)" # $$GITHUB_SHA
 
 	docker tag ${DOCKER_IMAGE_DEVELOPER_TOOLS}:${DOCKER_TAG_VERSION_DEVELOPER_TOOLS} \
   ${REGISTRY_URL}/${DOCKER_IMAGE_DEVELOPER_TOOLS}:${DOCKER_TAG_VERSION_DEVELOPER_TOOLS}