feat: allow user to specify/override outputs from the setup stage #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chatted with @bharathkkb out of band, and he suggested some changes. i'll move this to draft until its ready again. |
muncus
changed the title
|
/gcbrun |
|
Hey folks, can i get another /gcbrun on this PR? |
|
/gcbrun |
|
Tests are green. Is there anything else needed before this PR can be merged? If not, please merge it for me, as I do not have write permissions in this repo. Thanks! |
|
/gcbrun |
|
@bharathkkb - It sounds like you are familiar with the goal, would you have time to review? |
|
I resolved a merge conflict, so this will need another /gcbrun to get the 'cloud-foundation-cicd' tests run again. Once they pass, please merge. |
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to specify/override outputs from Setup stage. This enables users to iterate quickly when running blueprint tests on an existing project.
cft --stage verify --setup-var key=valueThese values are then accessible with
tft.GetTFSetupStringOutput("key"), as if it had come from the setup stage. Values specified in this way take precedence over actual setup outputs.Values are passed to the underlying
go testcommand using a set of prefixed environment variables. So--setup-var key=valuebecomesCFT_SETUP_key=value, which is parsed inNewTFBlueprintTest.This method currently works only for string values, but can be extended if desired.