Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user_agent module #56

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Add user_agent module #56

merged 1 commit into from
Jul 12, 2024

Conversation

MattIrv
Copy link
Collaborator

@MattIrv MattIrv commented Jul 12, 2024

I'm not using the user_agent package yet in this PR, but I'll send a follow-up one where I use it.

Unfortunately we have to use some internal class members from the underlying client libraries in order to update the user agent right now, but I've filed a feature request into googleapis/python-storage#1327 to improve this.

  • Tests pass
  • Appropriate changes to documentation are included in the PR

@MattIrv MattIrv requested a review from a team as a code owner July 12, 2024 18:43
Copy link
Collaborator

@bernardhan33 bernardhan33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, but we really are needing to hack all the way huh

@MattIrv MattIrv merged commit b307abd into main Jul 12, 2024
2 checks passed
@MattIrv MattIrv deleted the mirvine/useragent branch July 12, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants