skill with descriptive nl-sql generation - #147
Open
chen0040 wants to merge 10 commits into
Open
Conversation
Collaborator
Author
|
/gcbrun |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new evaluation dataset generation workflow, adding CI steps, configuration files, and extensive workspace setups for various grounding scenarios (such as DB schemas, query logs, and local code). It also updates the SKILL.md documentation with detailed instructions for the dataset generation skill. The review feedback highlights a critical runtime crash in hr_agent.py due to iterating over a None return value, corrupted placeholder text in the prompt instructions, a database name mismatch in dataset.json, and minor typos and grammatical errors in SKILL.md.
Collaborator
Author
|
/gcbrun |
Collaborator
Author
|
/gcbrun |
Collaborator
Author
|
/gcbrun |
Collaborator
Author
|
/gcbrun |
Collaborator
Author
|
/gcbrun |
Collaborator
Author
|
/gcbrun |
Collaborator
Author
|
/gcbrun |
1 similar comment
Collaborator
Author
|
/gcbrun |
Collaborator
Author
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new skill that is descriptive for nl-sql seed golden pair generation. It updates the comprehensive evaluation test suite for the seed evaluation dataset generation feature.
Key Changes
Descriptive Skill for Golden Pair Generation (
skills/autoctx-dataset-generation/SKILL.md)CI/CD Pipeline Enhancement (
.ci/cloudbuild.yaml)eval-dataset-gentest suiteNew Evaluation Test Suite (
evals/eval-dataset-gen/)Test Workspace Setup
tools.yamlfiles with database source and execution tool definitionsEvaluation Configuration
run_gemini_cli.yaml: Orchestrator configuration for Gemini CLI evaluationrun_claude.yaml: Orchestrator configuration for Claude Code evaluationDocumentation (
README.md)Testing