Skip to content

Commit

Permalink
remove path-matcher filter (#405)
Browse files Browse the repository at this point in the history
* remove path-matcher filter

Signed-off-by: Wayne Zhang <[email protected]>

* remove Pattern

Signed-off-by: Wayne Zhang <[email protected]>
  • Loading branch information
qiwzhang authored Nov 4, 2020
1 parent 74af9f6 commit 5355f8f
Show file tree
Hide file tree
Showing 28 changed files with 14 additions and 1,303 deletions.
33 changes: 0 additions & 33 deletions api/envoy/v9/http/common/base.proto
Original file line number Diff line number Diff line change
Expand Up @@ -19,39 +19,6 @@ package espv2.api.envoy.v9.http.common;
import "google/protobuf/duration.proto";
import "validate/validate.proto";

// Pattern defines a single pattern to match against
// incoming requests. This pattern matcher is not limited to HTTP requests.
//
// ```yaml
// pattern:
// uriTemplate: /foo/bar
// httpMethod: GET
// ```
message Pattern {
// URI template to match against as defined by
// [rfc6570](https://tools.ietf.org/html/rfc6570). For example, the
// following are valid URI templates:
//
// /pets
// /pets/{id}
// /dictionary/{term:1}/{term}
// /search{?q*,lang}
//
string uri_template = 1 [(validate.rules).string = {
// Must not be empty, at a minimum must be "/".
min_len: 1,
// Does not contain query params ('?', '&'), fragments ('#'), or invalid
// HTTP_HEADER_VALUE ('\r', '\n', '\0') characters.
pattern: '^[^?&#\\r\\n\\0]+$',
}];

// HTTP request method to match against as defined by
// [rfc7231](https://tools.ietf.org/html/rfc7231#page-21). For
// example: GET, HEAD, POST, PUT, DELETE.
string http_method = 2
[(validate.rules).string.well_known_regex = HTTP_HEADER_NAME];
}

message HttpUri {
// The uri string including the domain and path.
string uri = 1 [(validate.rules).string = {
Expand Down
25 changes: 0 additions & 25 deletions api/envoy/v9/http/path_matcher/BUILD

This file was deleted.

37 changes: 0 additions & 37 deletions api/envoy/v9/http/path_matcher/config.proto

This file was deleted.

4 changes: 0 additions & 4 deletions api/scripts/go_proto_gen.sh
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ cp -f bazel-bin/api/envoy/v9/http/common/base_go_proto_/github.com/GoogleCloudPl
bazel build //api/envoy/v9/http/service_control:config_go_proto
mkdir -p src/go/proto/api/envoy/v9/http/service_control
cp -f bazel-bin/api/envoy/v9/http/service_control/config_go_proto_/github.com/GoogleCloudPlatform/esp-v2/src/go/proto/api/envoy/v9/http/service_control/* src/go/proto/api/envoy/v9/http/service_control
# HTTP filter path_matcher
bazel build //api/envoy/v9/http/path_matcher:config_go_proto
mkdir -p src/go/proto/api/envoy/v9/http/path_matcher
cp -f bazel-bin/api/envoy/v9/http/path_matcher/config_go_proto_/github.com/GoogleCloudPlatform/esp-v2/src/go/proto/api/envoy/v9/http/path_matcher/* src/go/proto/api/envoy/v9/http/path_matcher
# HTTP filter path_rewrite
bazel build //api/envoy/v9/http/path_rewrite:config_go_proto
mkdir -p src/go/proto/api/envoy/v9/http/path_rewrite
Expand Down
1 change: 0 additions & 1 deletion src/envoy/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ envoy_cc_binary(
deps = [
"//src/envoy/http/backend_auth:filter_factory",
"//src/envoy/http/grpc_metadata_scrubber:filter_factory",
"//src/envoy/http/path_matcher:filter_factory",
"//src/envoy/http/path_rewrite:filter_factory",
"//src/envoy/http/service_control:filter_factory",
"@envoy//source/exe:envoy_main_entry_lib",
Expand Down
10 changes: 0 additions & 10 deletions src/envoy/http/backend_auth/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,6 @@ this filter overwrites the `Authorization` header with corresponding identity to
_Note_: this is a pass through filter. If the requested operation is not configured in the
filter config, the request will pass through unmodified.

## Prerequisites

This filter will not function unless the following filters appear earlier in the filter chain:

- [Path Matcher](../path_matcher/README.md)

This filter is designed to strongly integrate with the following filters:

- [Backend Routing](../backend_routing/README.md)

## Configuration

View the [backend auth configuration proto](../../../../api/envoy/v9/http/backend_auth/config.proto)
Expand Down
101 changes: 0 additions & 101 deletions src/envoy/http/path_matcher/BUILD

This file was deleted.

56 changes: 0 additions & 56 deletions src/envoy/http/path_matcher/README.md

This file was deleted.

Loading

0 comments on commit 5355f8f

Please sign in to comment.