fea(dea): Add support for tools metrics for DEA - #494
Merged
IsmailMehdi merged 2 commits intoJul 20, 2026
Merged
Conversation
minzznguyen
requested review from
IsmailMehdi,
helloeve and
prernakakkar-google
as code owners
July 14, 2026 23:44
minzznguyen
force-pushed
the
dea_skill_metrics
branch
from
July 14, 2026 23:47
d612c3b to
94d549f
Compare
minzznguyen
changed the title
minzznguyen
changed the title
Collaborator
|
/gcbrun |
graceqi-g
previously approved these changes
Jul 15, 2026
IsmailMehdi
reviewed
Jul 15, 2026
IsmailMehdi
left a comment
IsmailMehdi
left a comment
Collaborator
There was a problem hiding this comment.
Leaving the three blocker-level items inline. The rest of the review (regex fragility, URL-safe base64, missing .get() guards, per-turn reset, and a note on extractor test coverage) is posted separately — not repeated here.
added 2 commits
July 19, 2026 18:24
…lemetry - Implement stateless single-pass A2A ConversationToken decoding in gcp_data_engineering_agent.py - Extract function call parameters, outputs, and failure flags without state locks or diffing - Format structured per-turn tool telemetry inside conversation_history in dataengineeringagentevaluator.py - Add typed state attributes to EvalDeaRequest in dataengineeringagentinput.py
…ation_history agent string contract
minzznguyen
force-pushed
the
dea_skill_metrics
branch
from
July 20, 2026 04:09
0193929 to
7874e4d
Compare
graceqi-g
reviewed
Jul 20, 2026
| { | ||
| "user": "What is target workspace?", | ||
| "agent": "It is test-workspace.", | ||
| "agent_stats": {"tools": {"byName": {}}}, |
Collaborator
There was a problem hiding this comment.
can we add a more complex UT? it would be nice to test the tool deduplication logic you added is working correctly
Collaborator
|
/gcbrun |
IsmailMehdi
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement logic to extract tool names and details by:
gcp_data_engineering_agent.pydataengineeringagentinput.pyRecorded accumulated_tools when running
example_run_config.yaml[ 'provide_recommendations', 'validate_dataform_action', 'compile_dataform', 'write_dataform_file', 'get_schema_and_samples', 'assess_cleaning_quality' ]Captured Execution Details (tools_by_name)
definitions/simple_constant_view.sqlx,workflow_settings.yaml,package.json)