feat(dea): parameterize agent_name, env, domain to use different agent types support - #497
Conversation
4bb7702 to
810c19b
Compare
| @@ -1,6 +1,6 @@ | |||
| orchestrator: dea | |||
| dataset_format: dea-format | |||
| model_config: datasets/model_configs/gcp_data_engineering_agent_model.yaml | |||
There was a problem hiding this comment.
it looks like the other datasets keep the model config in the datasets/model_configs folder, should we instead update the existing config?
| "gcpResourceId": target_workspace | ||
| } | ||
| # Configure Agent Type extension | ||
| if self.agent_name.lower() in ("sparkagent", "spark_agent", "spark"): |
There was a problem hiding this comment.
since we are only accepting sparkagent or dataengieneringagent as specified in the readme, let's not allow/check other options
we can also refactor this into a match-case statement to improve readability slightly
|
/gcbrun |
0801348 to
bff4707
Compare
28b5ed0 to
6a22fef
Compare
| env: local # Target environment: "local", "staging", or "prod" (defaults to "prod") | ||
| port: 9876 # Required port for local Boq servers when env="local" | ||
| url_agent_name: sparkagent # URL path parameter appended to /v1/a2a/.../agents/{url_agent_name} | ||
| agent_type_uri: SPARK_AGENT # Persona string attached to AGENT_TYPE_URI metadata extension |
There was a problem hiding this comment.
instead of making agent_type_uri a separate config, let's keep a dictionary which takes the agent name and outputs what agent type uri value to specify in the extension, since it is 1 to 1
we can change the url_agent_name config to agent_type to make the association clear
There was a problem hiding this comment.
I also changed the name env to mode_env since it is making collision with the env config in run config since the two configs get merged in evaluator
| ) | ||
|
|
||
| if env == "local": | ||
| port = querygenerator_config.get("port") |
There was a problem hiding this comment.
we can have port default to the default port boq uses, i think it's 9876
59cd848 to
0222eb1
Compare
|
|
||
| if env == "local": | ||
| port = querygenerator_config.get("port", 9876) | ||
|
|
There was a problem hiding this comment.
nit: remove this empty line
0222eb1 to
3cb2b42
Compare
|
/gcbrun |
…ogleCloudPlatform#497) Co-authored-by: James Nguyen <jamesamn@google.com>
3 participants
Description
env(stagingvsprod),agent_name(sparkagentvsdataengineeringagent), and optionaldomainhost override inDataEngineeringAgentGenerator.AGENT_TYPE_URIextension (https://geminidataanalytics.googleapis.com/a2a/extensions/agenttype/v1) and mapssparkagentto string enum"SPARK_AGENT"in request metadata.datasets/dea-tools/example_model_config.yamland updatedexample_run_config.yamlandREADME.md.pytest), and exported outputs to BigQuery (bq-dataworkeragent-test.evalbench).Testing