ci(style): run pycodestyle over the whole repo, not just evalbench - #612
Merged
Merged
Conversation
The style check only covers the core library today, so viewer/ accumulated 283 violations. Clearing them lets the UI be linted in CI. Whitespace only, apart from five `if x: y` one-liners split across two lines.
omkargaikwad23
requested review from
IsmailMehdi,
helloeve and
prernakakkar-google
as code owners
September 17, 2026 12:53
Collaborator
Author
|
/gcbrun |
Zizmor blocks the PR on unpinned-uses, which is a mandatory check that cannot be suppressed inline. Match verify-package.yml: SHA-pinned actions, read-all permissions, and no persisted checkout credentials.
helloeve
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #608 — repo-wide lint cannot pass until the viewer cleanup lands.
Summary
The style job ran
pycodestyle evalbenchonly, so anything outside the core library was silently unlinted until someone remembered to add it. Pointing the job at the repo root inverts that default: new packages are covered automatically.Coverage goes from 264 to 285 tracked Python files — adding
viewer/(15), the non-converterdatasets/scripts (3),verifier/,.ci/, andnoxfile.py.Also in this change:
noxfile.py— fixes its oneE302..pycodestyle— excludesdatasets/db-engine-convertor(1183 violations, a self-contained sub-project; cleaning it is a separate change), plus.git,.venv, andbuildso a local run matches CI instead of walking the virtualenv.No new job and no path filter: pycodestyle needs no dependency install and the repo-wide run takes under 3 seconds.
Test plan
datasets/db-engine-convertorexclude is not path-dependentevalprotofiles and the 42 converter files