Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove inconsistent model variable naming #1701

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

jsondai
Copy link
Member

@jsondai jsondai commented Feb 5, 2025

fix: remove inconsistent model variable naming in evaluate_models_in_vertex_ai_studio_and_model_garden.ipynb

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • You are listed as the author in your notebook or README file.
    • Your account is listed in CODEOWNERS for the file(s).
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
  • Ensure the tests and linter pass (Run nox -s format from the repository root to format).
  • Appropriate docs were updated (if necessary)

Fixes #1691 🦕

@jsondai jsondai requested a review from a team as a code owner February 5, 2025 18:58
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@holtskinner holtskinner merged commit 3e8086b into main Feb 5, 2025
15 checks passed
@holtskinner holtskinner deleted the jsondai-patch-2 branch February 5, 2025 19:14
leebaro pushed a commit to leebaro/generative-ai that referenced this pull request Feb 7, 2025
)

fix: remove inconsistent model variable naming in
evaluate_models_in_vertex_ai_studio_and_model_garden.ipynb


Fixes GoogleCloudPlatform#1691  🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Inconsistent model variable naming in evaluate_models_in_vertex_ai_studio_and_model_garden.ipynb
2 participants