Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add notebook for BQML remote endpoint Blog #1704

Merged
merged 12 commits into from
Feb 7, 2025

Conversation

luseloso
Copy link
Member

@luseloso luseloso commented Feb 6, 2025

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [ X] Follow the CONTRIBUTING Guide.
  • [ X] You are listed as the author in your notebook or README file.
    • [ X] Your account is listed in CODEOWNERS for the file(s).
  • [ X] Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
  • [ X] Ensure the tests and linter pass (Run nox -s format from the repository root to format).
  • [ X] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@luseloso luseloso requested a review from a team as a code owner February 6, 2025 00:22
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jeffonelson jeffonelson self-requested a review February 6, 2025 01:04
Copy link
Contributor

@jeffonelson jeffonelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding comments for this notebook.

@luseloso
Copy link
Member Author

luseloso commented Feb 6, 2025

Just committed and push the edits. Please let me know if we can merge without the two current open items
@jeffonelson

@jeffonelson
Copy link
Contributor

@holtskinner review complete on our end. Are you able to approve from your side?

@holtskinner
Copy link
Collaborator

LGTM

@holtskinner holtskinner merged commit 07da250 into GoogleCloudPlatform:main Feb 7, 2025
6 checks passed
@anthonymaw
Copy link

anthonymaw commented Feb 7, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants