Skip to content

Conversation

cfloress
Copy link
Contributor

@cfloress cfloress commented Oct 3, 2025

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@cfloress cfloress requested review from a team as code owners October 3, 2025 23:37
Copy link

snippet-bot bot commented Oct 3, 2025

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 3, 2025
Copy link
Contributor

Summary of Changes

Hello @cfloress, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the golang-samples repository by adding new examples for advanced Generative AI capabilities. It provides practical demonstrations for model tuning, allowing users to fine-tune models with custom datasets, and introduces a "thinking generation" sample that illustrates how models can articulate their reasoning process. These additions aim to make it easier for developers to leverage the GenAI SDK for more sophisticated AI applications.

Highlights

  • GenAI Tuning Samples: Introduced new Go samples demonstrating how to create and manage supervised tuning jobs for Generative AI models, including creating a job, getting its status, and making predictions with the tuned endpoint.
  • GenAI Thinking Generation Sample: Added a new Go sample showcasing "thinking generation" with text using the GenAI SDK, specifically demonstrating how a model can provide a detailed thought process alongside its final answer.
  • Comprehensive Testing: Included corresponding system tests for both the new tuning and thinking generation samples to ensure their functionality and provide runnable examples.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds new Go samples for GenAI tuning and thinking generation. The changes look good overall, introducing useful examples. My review includes a few key suggestions to improve correctness and testability:

  • The system tests for tuning are currently broken because they rely on a hardcoded, invalid job name. I've suggested a refactoring to properly chain the tests.
  • There's an API version mismatch between creating a tuning job (v1beta1) and getting/using it (v1), which will likely cause runtime errors. I've recommended using v1beta1 consistently.
  • There is an unused parameter in one of the new functions, which should be removed for code clarity.

Addressing these points will ensure the new samples are robust and the tests are reliable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant