-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(genai): Add samples for tuning and thinking generation #5394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(genai): Add samples for tuning and thinking generation #5394
Conversation
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @cfloress, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds new Go samples for GenAI tuning and thinking generation. The changes look good overall, introducing useful examples. My review includes a few key suggestions to improve correctness and testability:
- The system tests for tuning are currently broken because they rely on a hardcoded, invalid job name. I've suggested a refactoring to properly chain the tests.
- There's an API version mismatch between creating a tuning job (
v1beta1
) and getting/using it (v1
), which will likely cause runtime errors. I've recommended usingv1beta1
consistently. - There is an unused parameter in one of the new functions, which should be removed for code clarity.
Addressing these points will ensure the new samples are robust and the tests are reliable.
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
go test -v ./..
(see Testing)gofmt
(see Formatting)go vet
(see Formatting)