Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AlloyDBInstance type, mapper and direct controller #3281

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maqiuyujoyce
Copy link
Collaborator

@maqiuyujoyce maqiuyujoyce commented Dec 3, 2024

Change description

Supported AlloyDBInstance type, mapper and direct controller

  • Changes in the AlloyDBInstance CRDs are non-breaking. Mostly caused by the format of the field descriptions and how we generate direct CRDs.
  • Added "direct" annotation to all the AlloyDBInstance in the alloydbinstance test cases.
  • Updated the AlloyDBInstance in the test cases to use the direct controller instead.
    • The golden files are updated based on the behavior of the direct controller, which are all expected. Note that the TF-based controller somehow does an additional reconciliation right after the successful creation. The direct reconciliation doesn't do it, which caused one less GET event. Another thing is that the EnsureFinalizer() step in TF-based reconciliation possibly increased the generation by one during reconciliation, so the generation value is different. Overall the values and behaviors look more reasonable in the direct controller test result.

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

Logs when running against the real GCP using the direct controller: #3361 Note that the dependent resources are all abandoned to save test time so please ignore the diffs unrelated to AlloyDBInstance.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from maqiuyujoyce. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maqiuyujoyce maqiuyujoyce force-pushed the 202411-alloydbinstance-type branch 3 times, most recently from 09d53c4 to 230a0fd Compare December 11, 2024 08:52
@maqiuyujoyce maqiuyujoyce changed the title [WIP] Support AlloyDBInstance type, mapper and direct controller Support AlloyDBInstance type, mapper and direct controller Dec 12, 2024
@maqiuyujoyce maqiuyujoyce force-pushed the 202411-alloydbinstance-type branch from 666917f to 2b857bd Compare December 13, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants