Enable klog in dynamic test #3330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Though still need to figure out how to enable the logs in the unified test. |
|
Thank you for fixing the klog setup in this test! |
yuwenma
reviewed
Dec 11, 2024
go.mod
Outdated
| @@ -79,6 +79,7 @@ require ( | |||
| k8s.io/apiextensions-apiserver v0.27.9 | |||
| k8s.io/apimachinery v0.27.11 | |||
| k8s.io/client-go v0.27.11 | |||
| k8s.io/klog/examples v0.0.0-20241125110655-fa118f5f4770 | |||
There was a problem hiding this comment.
Interesting. Why do we need to directly import this lib?
yuwenma
reviewed
Dec 11, 2024
pkg/test/main/testmain.go
Outdated
| @@ -27,6 +28,8 @@ import ( | |||
| testenvironment "github.com/GoogleCloudPlatform/k8s-config-connector/pkg/test/environment" | |||
| "github.com/GoogleCloudPlatform/k8s-config-connector/pkg/test/webhook" | |||
| cnrmwebhook "github.com/GoogleCloudPlatform/k8s-config-connector/pkg/webhook" | |||
| "k8s.io/klog/examples/util/require" | |||
There was a problem hiding this comment.
I suggest we do not import the examples lib. It is used for sample purposes but not used as a library. If it changes, Config Connector will break.
maqiuyujoyce
force-pushed
the
202412-enable-klog
branch
from
faeba8a to
d1abc8a
Compare
maqiuyujoyce
force-pushed
the
202412-enable-klog
branch
from
d1abc8a to
de3779c
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit c3a37f7
into
GoogleCloudPlatform:master
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Followed this guide to enable klog in dynamic test: https://github.com/kubernetes/klog?tab=readme-ov-file#coexisting-with-glog
Now we can see the logs from direct controllers with
-v=2.Tests you have done
make ready-prto ensure this PR is ready for review.