tool: unify --resource flag format across commands #3376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingyih
changed the title
jingyih
force-pushed
the
refactor_controller_generator
branch
from
80ea0e7 to
275d08a
Compare
yuwenma
reviewed
Jan 29, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jingyih
force-pushed
the
refactor_controller_generator
branch
from
69ee3a7 to
82309c6
Compare
|
Rebased to resolve merge conflict. |
Update "generate-controller" and "generate-direct-reconciler" commands to use the same "--resource Kind:ProtoName" flag format as other commands for consistency in the CLI interface.
jingyih
force-pushed
the
refactor_controller_generator
branch
from
82309c6 to
a7e8f33
Compare
|
Rebased to resolve merge conflict again! |
|
/lgtm |
google-oss-prow
bot
merged commit b27fe31
into
GoogleCloudPlatform:master
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update "generate-controller" and "generate-direct-reconciler" commands to use the same
--resource Kind:ProtoNameflag format as other commands for consistency in the CLI interface.