Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export: fix name collision on BigQueryTable #3383

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

export: fix name collision on BigQueryTable #3383

wants to merge 2 commits into from

Conversation

justinsb
Copy link
Collaborator

  • tests: add test coverage for exporting BigQueryTable
  • export: fix name collision on BigQueryTable

@justinsb
tests: add test coverage for exporting BigQueryTable
f0c7607
@justinsb
export: fix name collision on BigQueryTable
5761437 
Table IDs are unique only within the dataset, so we should include the table id in the name.
@google-oss-prow Google OSS Prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from justinsb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@justinsb