Adding an experimental multicluster ingress API #212
Conversation
|
@nikhiljindal: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
@nikhiljindal, few generic questions here.
- What is the correlation between
MultiClusterIngressand aMultiClusterService? How they are linked. - Can the API be reusable in hybrid environment or a non-gke environment?
| // MultiClusterIngressStatus is the status of a MultiClusterIngress. | ||
| type MultiClusterIngressStatus struct { | ||
| // VIP is the virtual IP address of the load balancer. | ||
| VIP string |
There was a problem hiding this comment.
- Can
VIPbe an array? - Is it possible that Service created in multiple clusters have provisioned a loadbalancers with different IP. How that can be handled or avoided?
| VIP string | ||
| } | ||
|
|
||
| // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object |
There was a problem hiding this comment.
I'm new so please forgive me if this is off-base, but it seems to me that this and similar on line 96 are causing linting to fail.
./experimental/pkg/apis/mci/v1alpha1/types.go:52:1: comment on exported type MultiClusterIngressList should be of the form "MultiClusterIngressList ..." (with optional leading article)
| // MultiClusterServiceStatus is the status of a MultiClusterService. | ||
| type MultiClusterServiceStatus struct{} | ||
|
|
||
| // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object |
There was a problem hiding this comment.
As with line 52, it seems to me that this is causing linting to fail.
./experimental/pkg/apis/mci/v1alpha1/types.go:96:1: comment on exported type MultiClusterServiceList should be of the form "MultiClusterServiceList ..." (with optional leading article)
First stab at defining a MultiClusterIngress API.
There are 2 high level resources here: MultiClusterIngress and MultiClusterService.
Key differences with the current CLI model:
Advantages:
This is still Work in Progress (WIP). Sharing the API definition early to get reviews. Please review and add comments.