Make cloudrunv2 containers' env a set

[dullest]

Fix hashicorp/terraform-provider-google#17607
CloudRun v1 had a similar fix #4860

Release Note Template for Downstream PRs (will be copied)

cloudrunv2: made env blocks a set

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[hao-nan-li]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 106 insertions(+), 94 deletions(-))
google-beta provider: Diff ( 2 files changed, 106 insertions(+), 94 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 4 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field template.containers.env changed from TypeList to TypeSet on google_cloud_run_v2_service - reference
• Field template.template.containers.env changed from TypeList to TypeSet on google_cloud_run_v2_job - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

[modular-magician]

Tests analytics

Total tests: 39
Passed tests: 36
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages

• cloudrunv2

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudRunV2Job_cloudrunv2JobFullUpdate|TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate|TestAccCloudRunV2Service_cloudrunv2ServiceGcsVolume

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudRunV2Job_cloudrunv2JobFullUpdate[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceFullUpdate[Debug log]
TestAccCloudRunV2Service_cloudrunv2ServiceGcsVolume[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[hao-nan-li]

Looks like this contains a breaking-change. This should be included in our major release 6.0.0 happening later this year. We are still preparing for it, instructions should be available next month.

[dullest]

Is there a possibility of making it minor instead of major release?
This really similar Cloud Run v1 PR has been released as minor bug fix accroding to the release note, 3.72.0 to 3.73.0 instead of waiting 4.0.0.
I also confirmed current terraform code is not impacted by the change.
I generated the provider with the change on this PR to check if it breaks or not, and if it fixes the issue.
The result is expected behavior here.

[hao-nan-li]

That PR was merged ~3 years ago. We are stricter now because we had experienced necessity to do rollbacks and patch releases when breaking-changes are released in minors.

[dullest]

It makes sense. I'll wait the major release.

[hao-nan-li]

Thank you for your understanding

[github-actions]

@dullest, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 14 days.

This notification can be disabled with the disable-automatic-closure label.

[dullest]

Could you keep opening this PR?

[github-actions]

@dullest, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 2 weekdays.

This notification can be disabled with the disable-automatic-closure label.

[github-actions]

@dullest, this PR is being closed due to inactivity.

[dullest]

Well, it seemed nothing I could do to keep it opening.
It's a bit sad to see the redo on someone else's new PR instead of reopening this.

[yanweiguo]

Well, it seemed nothing I could do to keep it opening. It's a bit sad to see the redo on someone else's new PR instead of reopening this.

A new PR is needed to be merged into FEATURE-BRANCH-major-release-6.0.0 anyway.

[dullest]

#10214 (review)
You folks might be too busy to share the instruction.
Anyway, since the issue will be fixed, it's not a big deal,
but it might have been better if we had had some communication earlier.