Add support for Regional Managed Instance Groups Resize Request (Dynamic Workload Scheduler)

[chayankumar999]

Added support for ResizeRequest feature for Regional Managed Instance Group in Beta.
Alternatively, added support for Regional ResizeRequest feature for R(IGM).

Release Note Template for Downstream PRs (will be copied)

`google_compute_region_resize_request`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[chayankumar999]

Hey @rileykarson, the PR is ready for review now.

[askubis]

Approval from the service team.

[rileykarson]

Some early comments; gonna assign an alternate reviewer as I'm a little low on cycles rn

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 503 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 6 files changed, 1982 insertions(+), 12 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 129 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1037
Passed tests: 962
Skipped tests: 73
Affected tests: 2

Click here to see the affected service packages

• compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeRegionResizeRequest_computeRmigResizeRequestExample
• TestAccRegionInstanceGroupManager_distributionPolicy

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccRegionInstanceGroupManager_distributionPolicy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Several tests terminated during RECORDING mode.

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[melinath]

A few initial comments - there are a bunch of Output Only fields; could you remove the [output only] comment on all of them? It'll be autogenerated for the docs already.

Test are currently failing due to a panic: https://ff1c11903cd752508336bf6d605215431f828a82ad4e72cf7e38c07-apidata.googleusercontent.com/download/storage/v1/b/ci-vcr-logs/o/beta%2Frefs%2Fheads%2Fauto-pr-11968%2Fartifacts%2F63e7ee8b-e1ac-435a-b4e1-515071e61c7c%2Fbuild-log%2Frecording_test.log?jk=AdvOr8vj7bivIo1lQpYAx_gOy9w8c8FAQmoDx_kXHpuIqZRj5-pdoFNEQp-sRHAajCkdpeXNuBCgsAHOI4vGOYkW0lD4-QPgFdoH0QgouxQRbrC6_TiZK6xH0QeqaPly0RRDKrVxQRAyqIuPpBQihwtKuzQ8bwczxBmH4uu6eeAttF4aQ9llLei4dYdFXUhcIsBoslhVTl1IjykC2bu9JXdRVlOlY4sJIbzwGI7BJTbBMB4kqPsqmaS-DANEsZXj_PD-l3zj6V1S4Z-OH9iTd8ifmiKwW-K7zajuagLKxGZN4gIS7qj9bItftZ-ovvtQyfs3jbVnG-6cG94U_4HVfHeBTQBK9wyhNHYZyT7ew9mNSzPFiSR25l3RwoGhQ7gUtXpZo22a4tsBnvEqKEzGCF45JqZLNoq_kIvuur-xHEJL1_1XHhOqxfdRIS8NmNmqK2hrIzyX0lLRhi3Xm0T-zlrIrTdijQFUTCI1nZHESSIbF4DCISVrBHkae-eOgVXpwggG3vvHH020Sw55miXQNLMyd3YjfbhqwLiCU9oojRjTX9hQ3eaFOCIymXLQF_hdWFCHVOe3hhvzHUjGsSf0NGqhijasL6dKyEFYSEFXqEW5U_E7SqPaBMFQrn2zz6KiitgDfov_iALdvV_4lr82o-u82RrKSEYOw8Cr71iJ3OPZ10rUo0_r6B0M-PvoVQC4l3kbhElDVhZOP3LAsOEKlXk7S38OgJoATIS-XLaFJJobK1-7tsPxneDoCHSXg1btNoJyCIekaZDkA7JyS3p7jIXisSmPtmvY4pCsCYPTUvM5M0Oci-vluxwi5B5xJ1b6qmm9Wed2bi-vCjIByjfwEztysO8ceIab1iDweKXmn7f1jfmtBM52iWpj5sxKrBjpnLprq-e1fo5JC_FKSBX_t6zyOQBUwhgC4dtTb5_JeGZvfv-tAH_uxOsi5db0MAyupycZ6r9AaPBrGdnwu86moQY899AUFj6Y5M0_AmRayRcPVsAQi-ffYTbL8kg9-j6AP2hQIZjIIZjVszNHYBCrmLmKdoDeX_0XGhKosSQpa7s21fsatKPRVYwLItzdxmzB_NWwoAx5fhzFeqTNfi2nopAU3jzAzpLu5vkMJdMd3j9vQ6O_nfLQew-xoH4UG7H6S1T_ATikg9fpdMIHiJocPX0T3lNlJGEMN0llgD8g1T2Mg3r6NHko5SRHWujNjzsr7n8dSQmFcxorxfMyodc4pXR3RKH9oV7f9Nt9qh79EJojm-CPLNhpHwExjz0EcYE&isca=1

corresponds to https://github.com/modular-magician/terraform-provider-google-beta/compare/auto-pr-11968-old..auto-pr-11968#diff-bd02d3aad4ce2654aeda448a399435f6fd360e72c9c8ee839d44529ac7d8b160R1028

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 491 insertions(+))
google-beta provider: Diff ( 4 files changed, 1976 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 129 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1041
Passed tests: 965
Skipped tests: 73
Affected tests: 3

Click here to see the affected service packages

• compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstanceConfidentialInstanceConfigMain
• TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain
• TestAccComputeResizeRequest_computeMigResizeRequestExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceConfidentialInstanceConfigMain [Error message] [Debug log]
TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain [Error message] [Debug log]
TestAccComputeResizeRequest_computeMigResizeRequestExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[chayankumar999]

All the failing tests are unrelated, you can ignore them and proceed further review if needed.

[github-actions]

@rileykarson @melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[melinath]

The schema looks fine apart from a couple things noted below. +1 the current failing tests are unrelated.

It would also probably be a good idea to move the deletion logic into a pre_delete rather than a custom_delete - more details below.

[melinath]

I think this would probably be easier to implement / maintain if you do it as a pre_delete instead of overriding the entire delete method - if I understand correctly, you just need to call a specific method before deletion if the resource is in a specific state, and otherwise it should just need to follow the normal deletion flow. Does that seem reasonable?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 489 insertions(+))
google-beta provider: Diff ( 4 files changed, 1972 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 129 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1055
Passed tests: 981
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages

• compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeResizeRequest_computeMigResizeRequestExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccComputeResizeRequest_computeMigResizeRequestExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[melinath]

Unless there's a strong objection or counterpoint, it would be great if you could switch to a pre-delete as described in #11968 (comment)

[chayankumar999]

Unless there's a strong objection or counterpoint, it would be great if you could switch to a pre-delete as described in #11968 (comment)

So far, I have no idea how it works (since this is my first PR with MMv1 resource). I am going through the docs to understand it and also looking at some example of pre-delete classes. Also maybe, for now we could use custom delete since it was used in the existing zonal resource. And later with the fix of of that bug that I mentioned earlier, we could try to move it to pre-delete for both resource after discussed with @askubis, since he has better context in terraform and the related dependency about the product. What do you think about that?

[melinath]

works for me!

[melinath]

LGTM

[melinath]

Merging is currently on hold due to some CI changes, so I'll come back to this later to merge it

[chayankumar999]

Merging is currently on hold due to some CI changes, so I'll come back to this later to merge it

Thanks a lot :)