Remove async operation.(waitms and path) #12514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottSuarez
commented
Dec 6, 2024
mmv1/api/async.go
Outdated
Comment on lines
85
to
91
|
|
||
| Path string `yaml:"path,omitempty"` | ||
|
|
||
| BaseUrl string `yaml:"base_url,omitempty"` | ||
|
|
||
| WaitMs int `yaml:"wait_ms,omitempty"` | ||
|
|
There was a problem hiding this comment.
I might need to leave it in the serializer otherwise this will break any existing PRs that use this.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
melinath
approved these changes
Dec 6, 2024
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
This was referenced Dec 6, 2024
amanMahendroo
pushed a commit
to amanMahendroo/magic-modules
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helps with hashicorp/terraform-provider-google#17098
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.