-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update serializer to remove unused async fields #12517
Draft
ScottSuarez
wants to merge
2
commits into
GoogleCloudPlatform:main
Choose a base branch
from
ScottSuarez:update-serializer-to-remove-unused-fields
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
import os | ||
|
||
def modify_yaml_files(): | ||
products_dir = 'mmv1/products' | ||
|
||
# Fields to remove under each section | ||
remove_fields = { | ||
'operation': {'path', 'wait_ms', 'kind'}, | ||
'result': {'path'}, | ||
'status': {'path', 'allowed', 'complete'}, | ||
'error': {'path', 'message'} | ||
} | ||
|
||
for product in os.listdir(products_dir): | ||
product_path = os.path.join(products_dir, product) | ||
if os.path.isdir(product_path): | ||
for root, _, files in os.walk(product_path): | ||
for file in files: | ||
if file.endswith('.yaml'): | ||
file_path = os.path.join(root, file) | ||
print(f"\nProcessing: {file_path}") | ||
|
||
with open(file_path, 'r') as f: | ||
lines = f.readlines() | ||
|
||
# Track state and indentation | ||
in_async = False | ||
current_section = None | ||
async_indent = 0 | ||
section_indent = 0 | ||
lines_to_keep = [] | ||
|
||
# Buffer for current section | ||
current_section_lines = [] | ||
current_section_has_content = False | ||
|
||
for i, line in enumerate(lines, 1): | ||
indent = len(line) - len(line.lstrip()) | ||
stripped = line.strip() | ||
|
||
# Check for async section | ||
if stripped.startswith('async:'): | ||
in_async = True | ||
async_indent = indent | ||
lines_to_keep.append(line) | ||
continue | ||
|
||
# Check for sections under async | ||
if in_async and any(stripped.startswith(f"{section}:") for section in remove_fields): | ||
# Process previous section if exists | ||
if current_section and current_section_has_content: | ||
lines_to_keep.extend(current_section_lines) | ||
|
||
current_section = next(section for section in remove_fields if stripped.startswith(f"{section}:")) | ||
section_indent = indent | ||
current_section_lines = [line] | ||
current_section_has_content = False | ||
continue | ||
|
||
# Process lines within a section | ||
if current_section and indent > section_indent: | ||
# Check if this is a field we want to remove | ||
field = stripped.split(':')[0] if ':' in stripped else None | ||
if field and field in remove_fields[current_section]: | ||
continue | ||
|
||
# If it's not a field to remove, keep track of content | ||
if stripped and not stripped.startswith('#'): | ||
current_section_has_content = True | ||
current_section_lines.append(line) | ||
else: | ||
# Leaving a section | ||
if current_section: | ||
if current_section_has_content: | ||
lines_to_keep.extend(current_section_lines) | ||
current_section = None | ||
current_section_lines = [] | ||
current_section_has_content = False | ||
|
||
# Check if we're leaving async section | ||
if in_async and indent <= async_indent and stripped: | ||
in_async = False | ||
|
||
lines_to_keep.append(line) | ||
|
||
# Handle last section if exists | ||
if current_section and current_section_has_content: | ||
lines_to_keep.extend(current_section_lines) | ||
|
||
# Write back only if we made changes | ||
if lines_to_keep != lines: | ||
print(f"Writing changes to {file_path}") | ||
with open(file_path, 'w') as f: | ||
f.writelines(lines_to_keep) | ||
else: | ||
print(f"No changes needed in {file_path}") | ||
|
||
if __name__ == "__main__": | ||
modify_yaml_files() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is here just in case something happens and someone else needs to run this script. Remove this script before checking in.