Add missing pagination for data source google_service_accounts

[bestefreund]

Adds pagination for querying service accounts

Fixes: hashicorp/terraform-provider-google#20920

Release Note Template for Downstream PRs (will be copied)

iam: fixed missing result by adding pagination for data source `google_service_accounts`.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 21 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 1 file changed, 21 insertions(+), 15 deletions(-))

[modular-magician]

Tests analytics

Total tests: 159
Passed tests: 127
Skipped tests: 30
Affected tests: 2

Click here to see the affected service packages

• resourcemanager

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccDataSourceGoogleServiceAccounts_basic
• TestAccEphemeralServiceAccountKey_basic

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleServiceAccounts_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[bestefreund]

Hi @BBBmau ,

please, have a look on this bugfix and let me know, if there's anything more I can contribute to resolve it.

Kind regards!

[BBBmau]

glad to see that there's a simple way to do pagination! If you're interested you can work on hashicorp/terraform-provider-google#19157

standardizing pagination is something we should really look into with more and more issues being brought up about it.

[bestefreund]

Hi @BBBmau ,

thank you very much!
I'll have a look on it.

Kind regards!

[BBBmau]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.