Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for ssl_config support for postgresql_profile #12771

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arunpoudel
Copy link

@arunpoudel arunpoudel commented Jan 15, 2025

Added support for ssl_config for postgresql_profile

Fixes hashicorp/terraform-provider-google#20929

Release Note Template for Downstream PRs (will be copied)

datastream: added `postgresql_profile.ssl_config` to `google_datastream_connection_profile`

Copy link

google-cla bot commented Jan 15, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 15, 2025
@arunpoudel arunpoudel marked this pull request as ready for review January 15, 2025 22:23
@github-actions github-actions bot requested a review from roaks3 January 15, 2025 22:24
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@arunpoudel arunpoudel marked this pull request as draft January 15, 2025 22:32
@arunpoudel arunpoudel force-pushed the main branch 3 times, most recently from 6b8fd35 to dbe7611 Compare January 15, 2025 22:45
@arunpoudel arunpoudel marked this pull request as ready for review January 15, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that need reviewer's approval to run presubmit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing sslConfig support for PostgressqlProfile in projects.locations.connectionProfiles.ConnectionProfile
2 participants