Skip sleep in VCR replaying mode #12785
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
modular-magician
added
the
awaiting-approval
wyardley
force-pushed
the
wyardley/20916
branch
from
dfa7579 to
b002004
Compare
wyardley
force-pushed
the
wyardley/20916
branch
from
b002004 to
441f471
Compare
In `SleepInSecondsForTest()`, skip the sleep when `VCR_MODE` is `REPLAYING`. This makes the assumption that the sleep is always related to a condition that's already mitigated by the fact that we're using prerecorded fixtures, but it could be extended later to override this behavior if necessary. Fixes hashicorp/terraform-provider-google#20916
wyardley
force-pushed
the
wyardley/20916
branch
from
441f471 to
1656389
Compare
wyardley
commented
Jan 17, 2025
| @@ -90,7 +91,10 @@ func SkipIfVcr(t *testing.T) { | |||
|
|
|||
| func SleepInSecondsForTest(t int) resource.TestCheckFunc { | |||
| return func(s *terraform.State) error { | |||
| time.Sleep(time.Duration(t) * time.Second) | |||
| // Assume we never want to sleep when we're in replaying mode. | |||
| if os.Getenv("VCR_MODE") != "REPLAYING" { | |||
There was a problem hiding this comment.
I tested this both with / without assignment, but gut is that this is probably good enough? it already seems to work fine / not error if the env var is not defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
SleepInSecondsForTest(), skip the sleep whenVCR_MODEisREPLAYING. This makes the assumption that the sleep is always related to a condition that's already mitigated by the fact that we're using prerecorded fixtures, but it could be extended later to override this behavior if necessary.Fixes hashicorp/terraform-provider-google#20916
Replaying mode with change:
without change (this one has a 5s sleep, so the difference is small, but you can see it more dramatically on something with a longer sleep)
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.