Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes that label starting with "__" are reserved for internal use case only in metrics labels #12882

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

7mako
Copy link

@7mako 7mako commented Jan 28, 2025

Fixes hashicorp/terraform-provider-google#20938

Release Note Template for Downstream PRs (will be copied)

monitoring: added more description to make it clear that label starting with "__" are reserved for internal use case only in metrics labels, and cannot be overwritten. 

@github-actions github-actions bot requested a review from SirGitsalot January 28, 2025 00:08
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 28, 2025
Copy link

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants