Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Adds readiness_probe support for google_cloud_run_service [google-beta] #13257

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

rafaeltello
Copy link
Contributor

cloudrun: added `readiness_probe` fields to `google_cloud_run_service` resource

readiness_probe already exists in v1 API for knative compatibility, but Cloud Run ignores it link. We're preparing to launch support for it

hashicorp/terraform-provider-google#21703

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 74 insertions(+))
google-beta provider: Diff ( 4 files changed, 613 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 188 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_service (68 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_service" "primary" {
  template {
    spec {
      containers {
        readiness_probe {
          failure_threshold = # value needed
          grpc {
            port    = # value needed
            service = # value needed
          }
          http_get {
            http_headers {
              name  = # value needed
              value = # value needed
            }
            path = # value needed
            port = # value needed
          }
          period_seconds  = # value needed
          timeout_seconds = # value needed
        }
      }
    }
  }
}

@modular-magician modular-magician requested a review from avianap March 4, 2025 23:08
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • cloudrun

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 74 insertions(+))
google-beta provider: Diff ( 4 files changed, 613 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 188 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_service (68 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_service" "primary" {
  template {
    spec {
      containers {
        readiness_probe {
          failure_threshold = # value needed
          grpc {
            port    = # value needed
            service = # value needed
          }
          http_get {
            http_headers {
              name  = # value needed
              value = # value needed
            }
            path = # value needed
            port = # value needed
          }
          period_seconds  = # value needed
          timeout_seconds = # value needed
        }
      }
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 54
Passed tests: 50
Skipped tests: 4
Affected tests: 0

Click here to see the affected service packages
  • cloudrun
  • networksecurity

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 74 insertions(+))
google-beta provider: Diff ( 4 files changed, 613 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 188 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_cloud_run_service (68 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_cloud_run_service" "primary" {
  template {
    spec {
      containers {
        readiness_probe {
          failure_threshold = # value needed
          grpc {
            port    = # value needed
            service = # value needed
          }
          http_get {
            http_headers {
              name  = # value needed
              value = # value needed
            }
            path = # value needed
            port = # value needed
          }
          period_seconds  = # value needed
          timeout_seconds = # value needed
        }
      }
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 32
Passed tests: 25
Skipped tests: 6
Affected tests: 1

Click here to see the affected service packages
  • cloudrun

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunService_probes

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunService_probes [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 74 insertions(+))
google-beta provider: Diff ( 4 files changed, 664 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 188 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 32
Passed tests: 25
Skipped tests: 6
Affected tests: 1

Click here to see the affected service packages
  • cloudrun

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunService_probes

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccCloudRunService_probes [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 74 insertions(+))
google-beta provider: Diff ( 4 files changed, 654 insertions(+), 14 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 188 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 32
Passed tests: 25
Skipped tests: 6
Affected tests: 1

Click here to see the affected service packages
  • cloudrun

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudRunService_probes

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCloudRunService_probes [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants