-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Adds readiness_probe support for google_cloud_run_service [google-beta] #13257
base: main
Are you sure you want to change the base?
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_cloud_run_service" "primary" {
template {
spec {
containers {
readiness_probe {
failure_threshold = # value needed
grpc {
port = # value needed
service = # value needed
}
http_get {
http_headers {
name = # value needed
value = # value needed
}
path = # value needed
port = # value needed
}
period_seconds = # value needed
timeout_seconds = # value needed
}
}
}
}
}
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR. View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_cloud_run_service" "primary" {
template {
spec {
containers {
readiness_probe {
failure_threshold = # value needed
grpc {
port = # value needed
service = # value needed
}
http_get {
http_headers {
name = # value needed
value = # value needed
}
path = # value needed
port = # value needed
}
period_seconds = # value needed
timeout_seconds = # value needed
}
}
}
}
}
|
Tests analyticsTotal tests: 54 Click here to see the affected service packages
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR. View the build log |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_cloud_run_service" "primary" {
template {
spec {
containers {
readiness_probe {
failure_threshold = # value needed
grpc {
port = # value needed
service = # value needed
}
http_get {
http_headers {
name = # value needed
value = # value needed
}
path = # value needed
port = # value needed
}
period_seconds = # value needed
timeout_seconds = # value needed
}
}
}
}
}
|
Tests analyticsTotal tests: 32 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 32 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 32 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
readiness_probe already exists in v1 API for knative compatibility, but Cloud Run ignores it link. We're preparing to launch support for it
hashicorp/terraform-provider-google#21703