-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v0.10.0 #2507
Release/v0.10.0 #2507
Conversation
🚲 PR staged at http://34.172.167.143 |
@@ -9,7 +23,7 @@ images: | |||
|
|||
serviceAccounts: | |||
# Specifies whether service accounts should be created. | |||
create: false | |||
create: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Was this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, service accounts are a good best practice and we decided to turn them on by default in kustomize-- might as well reflect that in Helm as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! We should eventually (out-of-scope for this PR):
remove the ServiceAccounts Kustomize component + add it to the default manifestssorry, forgot we already did this!- remove the option to remove ServiceAccounts in Helm (i.e.,
create: false
seems unnecessary).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #2508
This release works in the staging / PRs cluster, but the adservice is stuck in a segfault crash loop on the production cluster:
Edit 1: I spun up another random cluster and it deployed fine there too. The only cluster with that issue seems to be the GKE release cluster. Edit 2: I upgraded both the control plane and node pool on the release cluster to the latest version and still running into that segfault crash loop. |
Regarding the adservice error: we may need to create a new GKE (autopilot) cluster for production — similar to #2418. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for doing this, @bourgeoisor! 👏
File changes look good.
I see all v0.10.0
images in container registry + the Helm v0.10.0
artifact. ✅
Staging URL works. ✅
Draft release notes look good. Dang, you even counted the dependency updates. 💯
Issue: Since this contains a lot of edits to the Helm templates/manifests, we should check that Helm deploys successfully:
helm upgrade onlineboutique oci://us-docker.pkg.dev/online-boutique-ci/charts/onlineboutique \
--install
We can address everything about deploying to the production cluster after this PR has been merged.
Created #2509 for recreating the release GKE cluster. |
🚲 PR staged at http://34.172.167.143 |
This PR releases Online Boutique
v0.10.0
.Additionally, it brings the Helm chart templates up to par with any Kustomize base changes that has happened since December 2022. [diff]
I also updated the releasing docs [staging].
Closes #2496