Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v0.10.0 #2507

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Release/v0.10.0 #2507

merged 6 commits into from
Apr 24, 2024

Conversation

bourgeoisor
Copy link
Member

@bourgeoisor bourgeoisor commented Apr 23, 2024

This PR releases Online Boutique v0.10.0.

Additionally, it brings the Helm chart templates up to par with any Kustomize base changes that has happened since December 2022. [diff]

I also updated the releasing docs [staging].

Closes #2496

  • Checks are all passing
  • Deploy on the production environment
  • Manually test
  • Draft & publish release notes [draft]
  • Announce release

@bourgeoisor bourgeoisor requested review from yoshi-approver and a team as code owners April 23, 2024 19:32
Copy link

🚲 PR staged at http://34.172.167.143

@@ -9,7 +23,7 @@ images:

serviceAccounts:
# Specifies whether service accounts should be created.
create: false
create: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Was this intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, service accounts are a good best practice and we decided to turn them on by default in kustomize-- might as well reflect that in Helm as well.

Copy link
Collaborator

@NimJay NimJay Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! We should eventually (out-of-scope for this PR):

  1. remove the ServiceAccounts Kustomize component + add it to the default manifests sorry, forgot we already did this!
  2. remove the option to remove ServiceAccounts in Helm (i.e., create: false seems unnecessary).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #2508

@bourgeoisor
Copy link
Member Author

bourgeoisor commented Apr 23, 2024

This release works in the staging / PRs cluster, but the adservice is stuck in a segfault crash loop on the production cluster:

# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007fb423c7e522, pid=1, tid=16
#
# JRE version:  (21.0.2+13) (build )
# Java VM: OpenJDK 64-Bit Server VM (21.0.2+13-LTS, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, serial gc, linux-amd64)
# Problematic frame:
# C  [profiler_java_agent.so+0x897522]  std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::assign(char const*)+0xc
#
# Core dump will be written. Default location: /core.%e.1.%t
#
# Can not save log file, dump to screen..
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007fb423c7e522, pid=1, tid=16
#
# JRE version:  (21.0.2+13) (build )
# Java VM: OpenJDK 64-Bit Server VM (21.0.2+13-LTS, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, serial gc, linux-amd64)
# Problematic frame:
# C  [profiler_java_agent.so+0x897522]  std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::assign(char const*)+0xc
#
# Core dump will be written. Default location: /core.%e.1.%t

Edit 1: I spun up another random cluster and it deployed fine there too. The only cluster with that issue seems to be the GKE release cluster.

Edit 2: I upgraded both the control plane and node pool on the release cluster to the latest version and still running into that segfault crash loop.

@NimJay
Copy link
Collaborator

NimJay commented Apr 24, 2024

Regarding the adservice error: we may need to create a new GKE (autopilot) cluster for production — similar to #2418.
We can do that after this pull-request has been merged.

Copy link
Collaborator

@NimJay NimJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for doing this, @bourgeoisor! 👏

File changes look good.
I see all v0.10.0 images in container registry + the Helm v0.10.0 artifact. ✅
Staging URL works. ✅
Draft release notes look good. Dang, you even counted the dependency updates. 💯

Issue: Since this contains a lot of edits to the Helm templates/manifests, we should check that Helm deploys successfully:

helm upgrade onlineboutique oci://us-docker.pkg.dev/online-boutique-ci/charts/onlineboutique \
    --install

We can address everything about deploying to the production cluster after this PR has been merged.

@bourgeoisor
Copy link
Member Author

Created #2509 for recreating the release GKE cluster.

Copy link

🚲 PR staged at http://34.172.167.143

@bourgeoisor bourgeoisor merged commit b84b8b7 into main Apr 24, 2024
13 checks passed
@bourgeoisor bourgeoisor deleted the release/v0.10.0 branch April 24, 2024 19:54
@bourgeoisor bourgeoisor restored the release/v0.10.0 branch April 24, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release v0.10.0
2 participants