Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[email protected] #2614

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[email protected] #2614

wants to merge 2 commits into from

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Jul 2, 2024 •
edited
Loading

@mathieu-benoit mathieu-benoit requested review from yoshi-approver and a team as code owners July 2, 2024 15:00
@mathieu-benoit mathieu-benoit marked this pull request as draft July 2, 2024 15:00
@mathieu-benoit mathieu-benoit marked this pull request as ready for review July 2, 2024 15:38
@mathieu-benoit
Copy link
Contributor Author

Tested in there http://35.238.70.73/, ready for your review, thanks!

@mathieu-benoit
Copy link
Contributor Author

Actually it seems that there is an issue in the layout of Quantity in the /cart page.

Before:
image

After:
image

We could see that Quantity : 1 $24.99 is floating nowhere in the second image, while in the first image the associated Quantity: 1 $18.99 is well embedded in the row cart-summary-item-row.

Not mergeable yet.

I'm not a FE dev, anyone would like to look at this?

@mathieu-benoit mathieu-benoit marked this pull request as draft July 3, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mathieu-benoit