Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make git change detection in PR presubmits more robust. #1443

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

igorpeshansky
Copy link
Member

@igorpeshansky igorpeshansky commented Sep 26, 2023

Description

Switch from jitterbit/get-changed-files to Ana06/get-changed-files, to fix the errors it produces on force-pushed PR branches:

Error: The head commit for this pull_request event is not ahead of the base commit. Please submit an issue on this action's GitHub repo.

This is apparently a known issue: jitterbit/get-changed-files#11.

Note: an alternative would have been to use continue-on-error: true

Related issue

b/238471194

How has this been tested?

Force-pushed the branch, which ran the presubmit successfully.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

Copy link
Contributor

@avilevy18 avilevy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find! After considering it be a bit more, I think we should move to
Ana06/[email protected]

@igorpeshansky
Copy link
Member Author

Yeah, the latest version of Ana06/get-changed-files is v2.2.0, so we might as well switch to that.

@igorpeshansky igorpeshansky force-pushed the igorpeshansky-robust-github-actions branch from ca8de1d to b6fe973 Compare September 26, 2023 17:33
@igorpeshansky igorpeshansky merged commit 7083ce0 into master Sep 26, 2023
59 checks passed
@igorpeshansky igorpeshansky deleted the igorpeshansky-robust-github-actions branch September 26, 2023 22:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants