Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency isort to v6 #13102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate-bot
Copy link
Contributor

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
isort (changelog) ==5.11.5 -> ==6.0.0 age adoption passing confidence
isort (changelog) ==5.13.2 -> ==6.0.0 age adoption passing confidence

Release Notes

pycqa/isort (isort)

v6.0.0

Compare Source

Changes

💥 Breaking Changes

🚀 Features

🪲 Fixes

👷 Continuous Integration

📦 Dependencies

v5.13.2

Compare Source

v5.13.1

Compare Source

v5.13.0

Compare Source

v5.12.0

Compare Source

  • Removed support for Python 3.7
    • Fixed incompatiblity with latest poetry version
    • Added support for directory limitations within built in git hook

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested review from a team as code owners January 28, 2025 00:42
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 28, 2025
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request, submitted by Renovate Bot, updates the isort dependency across the python-docs-samples repository. The goal is to upgrade isort from versions 5.11.5 and 5.13.2 to version 6.0.0.

Here's a breakdown of the changes:

  • Intent: Upgrade the isort dependency to its latest version (6.0.0) for all supported Python versions (<=3.7 and >3.7).
  • Changes: The primary change is updating the requirements.txt file within the compute/client_library directory. Specifically, lines 1 and 2 are modified to reflect the new isort version:
--- a/compute/client_library/requirements.txt
+++ b/compute/client_library/requirements.txt
@@ -1,5 +1,5 @@
-isort==5.13.2; python_version > "3.7"
-isort==5.11.5; python_version <= "3.7"
+isort==6.0.0; python_version > "3.7"
+isort==6.0.0; python_version <= "3.7"
 black==24.8.0; python_version < "3.9"
 black==24.10.0; python_version >= "3.9"
 google-cloud-compute==1.19.1
  • Activity: This is an automated pull request generated by Renovate. The PR description includes detailed release notes for isort v6.0.0, highlighting breaking changes (removal of Python 3.8 support), new features (Python 3.13 support, performance improvements), bug fixes, and dependency updates.

I'll be checking for any conflicts or unintended consequences of this update. Expect my full review shortly.

And now, a little haiku to lighten the mood:

Code flows like a stream,
Isort's updates, clean and bright,
Bugs flee in the night.

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Jan 28, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2025
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request updates the isort dependency to v6.0.0. Upgrading dependencies is important for leveraging new features, bug fixes, and performance improvements. Since this update removes support for Python 3.7, ensure that your project no longer requires Python 3.7 compatibility. I've checked the changelog and summarized the key changes below.

Key Changes in isort 6.0.0:

  • Breaking: Removed support for Python 3.8.
  • Features: Added support for Python 3.13, improved performance, and other enhancements.
  • Fixes: Addressed various bugs related to diffing, line length, and more.

Given the removal of Python 3.8 support, it's crucial to test thoroughly after merging this PR, especially if you use Python 3.8 or later. Consider adding Python 3.13 to your test matrix to ensure ongoing compatibility with the latest Python versions. The provided diff only shows changes to the requirements.txt file. Please ensure all other necessary changes related to the isort upgrade are included in this PR or subsequent PRs. For example, if you have any custom isort configurations, they might need adjustments due to the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. owlbot:run Add this label to trigger the Owlbot post processor. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants