-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency isort to v6 #13102
base: main
Are you sure you want to change the base?
chore(deps): update dependency isort to v6 #13102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:
This pull request, submitted by Renovate Bot, updates the isort
dependency across the python-docs-samples
repository. The goal is to upgrade isort
from versions 5.11.5 and 5.13.2 to version 6.0.0.
Here's a breakdown of the changes:
- Intent: Upgrade the
isort
dependency to its latest version (6.0.0) for all supported Python versions (<=3.7 and >3.7). - Changes: The primary change is updating the
requirements.txt
file within thecompute/client_library
directory. Specifically, lines 1 and 2 are modified to reflect the newisort
version:
--- a/compute/client_library/requirements.txt
+++ b/compute/client_library/requirements.txt
@@ -1,5 +1,5 @@
-isort==5.13.2; python_version > "3.7"
-isort==5.11.5; python_version <= "3.7"
+isort==6.0.0; python_version > "3.7"
+isort==6.0.0; python_version <= "3.7"
black==24.8.0; python_version < "3.9"
black==24.10.0; python_version >= "3.9"
google-cloud-compute==1.19.1
- Activity: This is an automated pull request generated by Renovate. The PR description includes detailed release notes for
isort
v6.0.0, highlighting breaking changes (removal of Python 3.8 support), new features (Python 3.13 support, performance improvements), bug fixes, and dependency updates.
I'll be checking for any conflicts or unintended consequences of this update. Expect my full review shortly.
And now, a little haiku to lighten the mood:
Code flows like a stream,
Isort's updates, clean and bright,
Bugs flee in the night.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request updates the isort
dependency to v6.0.0. Upgrading dependencies is important for leveraging new features, bug fixes, and performance improvements. Since this update removes support for Python 3.7, ensure that your project no longer requires Python 3.7 compatibility. I've checked the changelog and summarized the key changes below.
Key Changes in isort 6.0.0:
- Breaking: Removed support for Python 3.8.
- Features: Added support for Python 3.13, improved performance, and other enhancements.
- Fixes: Addressed various bugs related to diffing, line length, and more.
Given the removal of Python 3.8 support, it's crucial to test thoroughly after merging this PR, especially if you use Python 3.8 or later. Consider adding Python 3.13 to your test matrix to ensure ongoing compatibility with the latest Python versions. The provided diff only shows changes to the requirements.txt
file. Please ensure all other necessary changes related to the isort
upgrade are included in this PR or subsequent PRs. For example, if you have any custom isort
configurations, they might need adjustments due to the update.
This PR contains the following updates:
==5.11.5
->==6.0.0
==5.13.2
->==6.0.0
Release Notes
pycqa/isort (isort)
v6.0.0
Compare Source
Changes
💥 Breaking Changes
🚀 Features
as
imports (#2340) @DanielNoordpre-commit autoupdate
(#2321) @kurtmckee🪲 Fixes
--diff
to be used with--jobs
(#2302) @mnakamawemake
has 80 chars hard limit, not 79 (#2241) @sobolevnmain
(#2320) @DanielNoordsort_reexports
code mangling (#2283) @Helveg👷 Continuous Integration
actions/cache@v2
usage (#2322) @kurtmckeepre-commit
(#2296) @matthewhughes934📦 Dependencies
poetry
to2.0.1
(#2341) @DanielNoordv5.13.2
Compare Source
v5.13.1
Compare Source
v5.13.0
Compare Source
v5.12.0
Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.