-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cloudrun): migrate region tags for dockerfiles and yaml from run folder - part 2 - step 3 #13105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm currently reviewing this pull request and will provide a full review shortly. In the meantime, here's a quick summary for you and other reviewers to get up to speed:
This pull request, "chore(cloudrun): migrate region tags for dockerfiles and yaml from run folder - part 2 - step 3", aims to migrate region tags in Dockerfiles and YAML files related to Cloud Run. It addresses internal issues b/347349975 and b/347349649. The changes are focused on removing redundant or obsolete region tags from the following files:
run/pubsub/Dockerfile
(Lines 16 and 44 removed)run/system-package/Dockerfile
(Lines 23 and 27 removed)
The changes primarily involve removing commented-out lines related to region tags, streamlining the Dockerfiles. The author has confirmed that tests and lint checks have passed.
I'll have a more detailed review shortly, including a check for any potential side effects of these changes.
Here's a little haiku to brighten your day:
Tags cleaned, code bright,
Cloud Run now runs smoothly,
Joy fills the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request removes region tags for the generic Cloud Run service. It correctly follows the sample guidelines and includes necessary updates to the README.
I noticed that the generic Cloud Run tag cloudrun_pubsub_dockerfile
was removed. It's important to confirm that this tag is no longer needed and won't impact any documentation or other dependencies.
Here is the summary of changes. You are about to delete 2 region tags.
This comment is generated by snippet-bot.
|
I see the documents have been updated by cl/720655627 and confirmed of success in CP. Checking source code for Page 1 and Page 2, the region has been updated:
Page 2
|
As per discussion with our team, we need to fix the region tag I'll retry this PR again when migration is finished for Node, Go and .NET. |
Conflicting region tags for Go, Node and dotnet/csharp repos are fixed now. This PR is ready to be reviewed. |
Description
Fixes Internal:
b/347349975
b/347349649
Checklist
nox -s py-3.12
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)