-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gae): delete 'flask' samples from standard folder #13117
base: main
Are you sure you want to change the base?
chore(gae): delete 'flask' samples from standard folder #13117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm currently reviewing this pull request and will provide feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:
This pull request, chore(gae): delete 'flask' samples from standard folder, aims to remove the Flask samples from the App Engine standard folder. The description mentions it fixes internal issues b/347349937, b/347350892, and b/347350807.
The following files were modified:
appengine/standard/flask/hello_world/.gitignore
- Thelib
entry was removed.appengine/standard/flask/hello_world/README.md
- The entire file was deleted.appengine/standard/flask/hello_world/app.yaml
- The entire file was deleted.appengine/standard/flask/hello_world/main.py
- The entire file was deleted.appengine/standard/flask/hello_world/main_test.py
- The entire file was deleted.appengine/standard/flask/tutorial/.gitignore
- Thelib
entry was removed.appengine/standard/flask/tutorial/README.md
- The entire file was deleted.appengine/standard/flask/tutorial/app.yaml
- The entire file was deleted.appengine/standard/flask/tutorial/appengine_config.py
- The entire file was deleted.appengine/standard/flask/tutorial/main.py
- The entire file was deleted.appengine/standard/flask/tutorial/main_test.py
- The entire file was deleted.appengine/standard/flask/tutorial/requirements-test.txt
- The entire file was deleted.appengine/standard/flask/tutorial/requirements.txt
- The entire file was deleted.appengine/standard/flask/tutorial/static/style.css
- The entire file was deleted.appengine/standard/flask/tutorial/templates/form.html
- The entire file was deleted.appengine/standard/flask/tutorial/templates/submitted_form.html
- The entire file was deleted.
Essentially, this PR completely removes the Flask-based samples from the App Engine standard directory.
Here's a little haiku to lighten the mood:
Code flows like a stream,
Deleting files, clean and swift,
A simpler program.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request removes the Flask samples from the appengine/standard
directory. This change aligns with the deprecation of Python 2.7, which is required for these samples, in App Engine standard. Removing these outdated samples helps to maintain the relevance and clarity of the repository. The changes are well-organized and straightforward. The updated README for the appengine/standard directory clearly reflects the removal of the Flask samples, which is good. The commit messages are clear and concise, and the pull request description provides sufficient context and references the relevant internal bug reports. Overall, this is a well-executed cleanup effort.
I noticed that the PR description mentions following sample guidelines, but the checklist item for updating the README is not checked. Since the appengine/standard/README.md
file is affected by this change, it should be updated to reflect the removal of the Flask samples. I've included a suggestion for the README update below.
Here is the summary of changes. You are about to delete 8 region tags.
This comment is generated by snippet-bot.
|
Description
Fixes Internal:
b/347349937
b/347350892
b/347350807
Checklist