Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(endpoints): migrate region tag step 1 - add new tag to openapi-appengine.yaml #13121

Conversation

eapl-gemugami
Copy link
Contributor

Description

Fixes Internal: b/393578122

Checklist

@product-auto-label product-auto-label bot added api: endpoints Issues related to the Cloud Endpoints API. samples Issues that are directly related to samples. labels Jan 31, 2025
Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request, chore(endpoints): add new region tag to open-appengine.yaml, aims to add a new region tag to the open-appengine.yaml file. The changes are focused on adding a new region tag to the existing openapi-appengine.yaml file. Specifically:

  • Intent: To add a new region tag to the open-appengine.yaml file, likely for improved clarity or to address a specific issue (b/393578122).
  • Changes:
    • Two lines were added to endpoints/getting-started/openapi-appengine.yaml:
      • Line 15: # [START endpoints_swagger_appengine_yaml_python] was added.
      • Line 24: # [END endpoints_swagger_appengine_yaml_python] was added.

The author, eapl-gemugami, has indicated that tests and lint checks have passed. They've also followed the sample guidelines and requested a merge once approved.

Here's a little haiku to lighten the mood:

Tags add clarity's light,
Code's path now shines more brightly,
Review's swift and kind.

Looking forward to discussing this further!

Best,
Gemini

@eapl-gemugami eapl-gemugami changed the title chore(endpoints): add new region tag to open-appengine.yaml chore(endpoints): migrate region tag step 1 - add new tag to open-appengine.yaml Jan 31, 2025
@eapl-gemugami eapl-gemugami added the snippet-bot:force-run Force snippet-bot runs its logic label Jan 31, 2025
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Jan 31, 2025
Copy link

snippet-bot bot commented Jan 31, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request adds a new region tag to the openapi-appengine.yaml file. This change is positive and improves the documentation's integration with the sample code. The region tags adhere to the guidelines in the AUTHORING_GUIDE.md file. No issues were found with the YAML file itself, and the added tags are correctly formatted.

@eapl-gemugami eapl-gemugami marked this pull request as ready for review January 31, 2025 17:54
@eapl-gemugami eapl-gemugami requested review from a team as code owners January 31, 2025 17:54
@iennae iennae merged commit ba64b94 into GoogleCloudPlatform:main Feb 5, 2025
11 checks passed
@eapl-gemugami eapl-gemugami deleted the paradalicea/chore/endpoints/fix-region-tag-getting-started-openapi-appengine-yaml branch February 5, 2025 17:39
@eapl-gemugami eapl-gemugami changed the title chore(endpoints): migrate region tag step 1 - add new tag to open-appengine.yaml chore(endpoints): migrate region tag step 1 - add new tag to openapi-appengine.yaml Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: endpoints Issues related to the Cloud Endpoints API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants