-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(endpoints): migrate region tag step 1 - add new tag to openapi-appengine.yaml #13121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:
This pull request, chore(endpoints): add new region tag to open-appengine.yaml, aims to add a new region tag to the open-appengine.yaml
file. The changes are focused on adding a new region tag to the existing openapi-appengine.yaml
file. Specifically:
- Intent: To add a new region tag to the
open-appengine.yaml
file, likely for improved clarity or to address a specific issue (b/393578122). - Changes:
- Two lines were added to
endpoints/getting-started/openapi-appengine.yaml
:- Line 15:
# [START endpoints_swagger_appengine_yaml_python]
was added. - Line 24:
# [END endpoints_swagger_appengine_yaml_python]
was added.
- Line 15:
- Two lines were added to
The author, eapl-gemugami, has indicated that tests and lint checks have passed. They've also followed the sample guidelines and requested a merge once approved.
Here's a little haiku to lighten the mood:
Tags add clarity's light,
Code's path now shines more brightly,
Review's swift and kind.
Looking forward to discussing this further!
Best,
Gemini
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request adds a new region tag to the openapi-appengine.yaml
file. This change is positive and improves the documentation's integration with the sample code. The region tags adhere to the guidelines in the AUTHORING_GUIDE.md file. No issues were found with the YAML file itself, and the added tags are correctly formatted.
Description
Fixes Internal: b/393578122
Checklist
nox -s py-3.13
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)