-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gae): delete samples in flexible: /extending_runtime and /disk #13122
chore(gae): delete samples in flexible: /extending_runtime and /disk #13122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:
This pull request, chore(gae): delete samples in flexible: /extending_runtime
and /disk
, aims to delete sample applications located in the appengine/flexible/extending_runtime
and appengine/flexible/disk
directories. The intent is to address internal issues b/347349429 and b/347349908.
Here's a breakdown of the changes:
- Deleted Files:
appengine/flexible/disk/app.yaml
(lines 1-20)appengine/flexible/disk/main.py
(lines 1-94)appengine/flexible/disk/main_test.py
(lines 1-24)appengine/flexible/disk/noxfile_config.py
(lines 1-38)appengine/flexible/disk/requirements-test.txt
(line 1)appengine/flexible/disk/requirements.txt
(lines 1-2)appengine/flexible/extending_runtime/.dockerignore
(lines 1-8)appengine/flexible/extending_runtime/Dockerfile
(lines 1-34)appengine/flexible/extending_runtime/app.yaml
(lines 1-16)appengine/flexible/extending_runtime/main.py
(lines 1-58)appengine/flexible/extending_runtime/main_test.py
(lines 1-32)appengine/flexible/extending_runtime/noxfile_config.py
(lines 1-38)appengine/flexible/extending_runtime/requirements-test.txt
(line 1)appengine/flexible/extending_runtime/requirements.txt
(lines 1-2)
The author has indicated that all tests pass using nox -s py-3.13
.
Let's keep the review process efficient and effective!
Short poem:
Code deleted, clean and neat,
Issues fixed, a sweet defeat,
For bugs that once did reign.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request removes sample code related to extending runtime and disk management in the App Engine flexible environment. It addresses internal bugs b/347349429 and b/347349908. The changes are appropriate and well-organized, effectively removing the outdated samples and their associated files. The checklist confirms adherence to sample guidelines and successful test execution. I've summarized the referenced elements from the style guide below.
Sample Guidelines from AUTHORING_GUIDE.MD referenced:
- Folder Location: The deleted samples were correctly located within the
appengine/flexible
directory, adhering to the guidelines. - Python Versions: The removal of these samples aligns with the current supported Python versions, as the samples may have been outdated.
- License Header: The removal of the license headers is appropriate since the entire files are being deleted.
- Dependencies: The removal of
requirements.txt
andrequirements-test.txt
is correct, as they are no longer needed. - README File: The update to the top-level
appengine/flexible/README.md
file to reflect the removal of these samples is recommended.
Here is the summary of changes. You are about to delete 4 region tags.
This comment is generated by snippet-bot.
|
Description
Fixes Internal:
b/347349429
b/347349908
Checklist
nox -s py-3.13
(see Test Environment Setup)