-
Notifications
You must be signed in to change notification settings - Fork 68
Added support for fetching secrets based on labels #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Please plan to add e2e test or add a load test at load-test.sh. May be this is a good opportunity to use labels in load test. |
We have added load test for fetching multiple secrets based on labels. |
@abheda-crest this will require additional permission to be configured on Secret Manager side, right? |
Yes, we would require the Reference: https://cloud.google.com/secret-manager/docs/access-control#secretmanager.viewer |
Can you please update the documentation? |
I have updated the documentation to include additional Secret Manager permission. |
README.md
Outdated
@@ -60,6 +60,11 @@ $ rm secret.data | |||
$ gcloud secrets add-iam-policy-binding testsecret \ | |||
--member=serviceAccount:gke-workload@$PROJECT_ID.iam.gserviceaccount.com \ | |||
--role=roles/secretmanager.secretAccessor | |||
|
|||
# grant the new service account permission to list the secrets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If secrets will be fetched using the label
Add this condition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the condition.
The PR focuses on retrieving secrets based on specified labels.
Related to: #384
We have tested this with the following scenarios:
(Location value provided in labels)