Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Enroot to install optional dependencies #224

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

cdunbar13
Copy link
Collaborator

Added new role for nvidia container to update the repos for debian or redhat based OSs.

Updated the enroot profile to be dependent on adding the nvidia repo, then optionally install the optional dependencies based on a variable enroot_install_optional_deps.

Image built on Debian and tested on A3U VMs successfully.

Testing included downloading the pytorch container, and building NCCL tests. Currently testing image building on RL8

Removing tty from gpg dearmor to prevent error in ansible build
@cdunbar13 cdunbar13 force-pushed the enroot-nvidia-container-update branch from 50bd65a to 8da0bed Compare October 16, 2024 17:13
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes in efficiency and naming.

ansible/roles/nvidia_container/defaults/main.yml Outdated Show resolved Hide resolved
ansible/roles/nvidia_container/tasks/os/debian.yml Outdated Show resolved Hide resolved
ansible/roles/nvidia_container/tasks/os/debian.yml Outdated Show resolved Hide resolved
ansible/roles/enroot/meta/main.yml Outdated Show resolved Hide resolved
@tpdownes tpdownes assigned cdunbar13 and unassigned tpdownes Oct 16, 2024
@cdunbar13 cdunbar13 force-pushed the enroot-nvidia-container-update branch 2 times, most recently from 8c8dfbd to 5bc9cac Compare October 16, 2024 20:52
@cdunbar13 cdunbar13 force-pushed the enroot-nvidia-container-update branch from 5bc9cac to c3fe576 Compare October 17, 2024 13:30
@cdunbar13 cdunbar13 requested a review from tpdownes October 17, 2024 13:32
@cdunbar13 cdunbar13 assigned tpdownes and unassigned cdunbar13 Oct 17, 2024
@tpdownes
Copy link
Member

Noting location of NVIDIA Container Toolkit:

https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/latest/install-guide.html

@tpdownes tpdownes assigned cdunbar13 and unassigned tpdownes Oct 17, 2024
@cdunbar13 cdunbar13 merged commit b3a4339 into master Oct 17, 2024
2 checks passed
@cdunbar13 cdunbar13 deleted the enroot-nvidia-container-update branch October 17, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants