-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Enroot to install optional dependencies #224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing tty from gpg dearmor to prevent error in ansible build
cdunbar13
force-pushed
the
enroot-nvidia-container-update
branch
from
October 16, 2024 17:13
50bd65a
to
8da0bed
Compare
tpdownes
requested changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes in efficiency and naming.
cdunbar13
force-pushed
the
enroot-nvidia-container-update
branch
2 times, most recently
from
October 16, 2024 20:52
8c8dfbd
to
5bc9cac
Compare
cdunbar13
force-pushed
the
enroot-nvidia-container-update
branch
from
October 17, 2024 13:30
5bc9cac
to
c3fe576
Compare
Noting location of NVIDIA Container Toolkit: https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/latest/install-guide.html |
tpdownes
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new role for nvidia container to update the repos for debian or redhat based OSs.
Updated the enroot profile to be dependent on adding the nvidia repo, then optionally install the optional dependencies based on a variable
enroot_install_optional_deps
.Image built on Debian and tested on A3U VMs successfully.
Testing included downloading the pytorch container, and building NCCL tests. Currently testing image building on RL8