Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update subnetwork_project default to null for v6 #230

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Update subnetwork_project default to null for v6 #230

merged 1 commit into from
Nov 1, 2024

Conversation

alyssa-sm
Copy link
Contributor

@alyssa-sm alyssa-sm commented Oct 30, 2024 •
edited
Loading

This PR updates the default value we set for subnetwork_project to null.

Passed the tests below:

  • PR-test-hpc-slurm-chromedesktop-v5-legacy
  • PR-test-ps-slurm
  • PR-test-slurm-gcp-v5-rocky8
  • PR-test-slurm-gcp-v5-startup-scripts-v5-legacy
  • PR-test-slurm-gcp-v6-startup-scripts
  • PR-test-slurm-gcp-v6-tpu

@alyssa-sm alyssa-sm self-assigned this Oct 30, 2024
@alyssa-sm alyssa-sm requested a review from tpdownes October 31, 2024 16:31
@alyssa-sm alyssa-sm assigned tpdownes and unassigned alyssa-sm Oct 31, 2024
tpdownes
tpdownes approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that all subnetwork_project fields either default to null or have no default.

@tpdownes tpdownes assigned alyssa-sm and unassigned tpdownes Nov 1, 2024
@alyssa-sm alyssa-sm merged commit d0b6579 into master Nov 1, 2024
3 checks passed
@alyssa-sm alyssa-sm deleted the change-v6-subnetwork-project-default-to-null branch November 1, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpdownes tpdownes tpdownes approved these changes

Assignees

@alyssa-sm alyssa-sm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alyssa-sm @tpdownes