Updating google-beta for instance template to allow for new nic-types #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to minimum version of 6.13.0 for instance_template as that is the minimum for using the MRDMA and IRDMA nic_types.
Testing by running updating the Toolkit to use the a4c3a89 ref of the slurm-gcp modules, and running against a few different Slurm integration tests
slurm-gcp-v6-ubuntu - passed
slurm-gcp-v6-static - passed
hpc-enterprise-slurm - passed
hcls - ongoing