Add topic_message_retention_duration property to pubsub_topics module (…

…#1170)
GoogleCloudPlatform · Jan 6, 2023 · edacaa4 · edacaa4
1 parent 3c7c873
commit edacaa4
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 0 deletions.
diff --git a/docs/tfengine/schemas/resources.md b/docs/tfengine/schemas/resources.md
@@ -211,6 +211,7 @@
 | pubsub_topics.push_subscriptions.ack_deadline_seconds | Deadline to wait for acknowledgement. | integer | false | - | - |
 | pubsub_topics.push_subscriptions.name | Name of subscription. | string | true | - | - |
 | pubsub_topics.push_subscriptions.push_endpoint | Name of endpoint to push to. | string | false | - | - |
+| pubsub_topics.topic_message_retention_duration | Message retention duration in seconds. | string | false | - | - |
 | secrets | [Module](https://www.terraform.io/docs/providers/google/r/secret_manager_secret.html) | array() | false | - | - |
 | secrets.resource_name | Override for Terraform resource name. If unset, defaults to normalized secret_id. Normalization will make all characters alphanumeric with underscores. | string | false | - | - |
 | secrets.secret_data | Data of the secret. If unset, should be manually set in the GCP console. | string | false | - | - |

diff --git a/examples/tfengine/generated/team/project_data/main.tf b/examples/tfengine/generated/team/project_data/main.tf
@@ -245,6 +245,7 @@ module "topic" {
       push_endpoint = "https://example.com"
     },
   ]
+  topic_message_retention_duration = "86400s"
   depends_on = [
     module.project
   ]

diff --git a/examples/tfengine/modules/team.hcl b/examples/tfengine/modules/team.hcl
@@ -497,6 +497,7 @@ template "project_data" {
             name = "pull-subscription"
           }
         ]
+        topic_message_retention_duration = "86400s"
       }]
     }
     terraform_addons = {

diff --git a/templates/tfengine/components/resources/pubsub_topics/main.tf b/templates/tfengine/components/resources/pubsub_topics/main.tf
@@ -30,6 +30,7 @@ module "{{resourceName . "name"}}" {
 
   {{hclField . "pull_subscriptions" -}}
   {{hclField . "push_subscriptions" -}}
+  {{hclField . "topic_message_retention_duration" -}}
 
   depends_on = [
     module.project

diff --git a/templates/tfengine/recipes/resources.hcl b/templates/tfengine/recipes/resources.hcl
@@ -1140,6 +1140,10 @@ schema = {
             description = "Name of the topic."
             type        = "string"
           }
+          topic_message_retention_duration = {
+            description = "Message retention duration in seconds."
+            type        = "string"
+          }
           labels = {
             description = "Labels to set on the topic."
             type        = "object"
-Original file line number
+Diff line change
@@ Expand Up / @@ -497,6 +497,7 @@ template "project_data" { @@
                 name = "pull-subscription"
               }
             ]
+            topic_message_retention_duration = "86400s"
           }]
         }
         terraform_addons = {
@@ Expand Down @@